Solari: Reduce temporal shadow lag #25046
Open
JMS55 wants to merge 4 commits into
Open
Conversation
JMS55
added
A-Rendering
stuartparmenter
added a commit
to stuartparmenter/bevy
that referenced
this pull request
Jul 18, 2026
Per-frame GPU-written vertex/index buffers become TLAS instances via entity-keyed BLASes. Geometry BLAS builds fold into the TLAS build encoder. Geometry BLASes double-buffer (GeometryBlasEntry::previous_blas) so the previous-frame TLAS retained for temporal MIS visibility (bevyengine#25046) keeps referencing an intact BLAS instead of one rebuilt in place this frame.
stuartparmenter
approved these changes
Jul 18, 2026
SparkyPotato
approved these changes
Jul 20, 2026
SparkyPotato
left a comment
SparkyPotato
left a comment
Contributor
There was a problem hiding this comment.
The seconds TLAS scares me a bit but looks good otherwise lol
JMS55
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce DI shadow lag (doesn't seem to do much for GI, but hard to tell) by using the previous-frame TLAS for visibility testing in MIS when merging the temporal reservoir in.
This does cost more VRAM.
Thanks to @stuartparmenter for the idea.