[Merged by Bors] - [assets] properly set LoadState with invalid asset extension
#2318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanSWard
added
A-Assets
|
bors r+ |
uhhh, |
|
bors try |
|
Weiiird |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 8, 2021
# Objective - Currently, when calling any of the `AssetServer`'s `load` functions, if the extension does not exist for the given path, the returned handle's load state is always `LoadState::NotLoaded`. - This is due to the `load_async` function early returning without properly creating a `SourceInfo` for the requested asset. - Fixes #2261 ## Solution - Add the `SourceInfo` prior to checking for valid extension loaders. And set the `LoadState` to `Failed` if the according loader does not exist.
tryBuild succeeded: |
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
LoadState with invalid asset extensionLoadState with invalid asset extension
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
…ngine#2318) # Objective - Currently, when calling any of the `AssetServer`'s `load` functions, if the extension does not exist for the given path, the returned handle's load state is always `LoadState::NotLoaded`. - This is due to the `load_async` function early returning without properly creating a `SourceInfo` for the requested asset. - Fixes bevyengine#2261 ## Solution - Add the `SourceInfo` prior to checking for valid extension loaders. And set the `LoadState` to `Failed` if the according loader does not exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
AssetServer'sloadfunctions, if the extension does not exist for the given path, the returned handle's load state is alwaysLoadState::NotLoaded.load_asyncfunction early returning without properly creating aSourceInfofor the requested asset.LoadState::NotLoadedwhen trying to load an asset with an invalid extension. #2261Solution
SourceInfoprior to checking for valid extension loaders. And set theLoadStatetoFailedif the according loader does not exist.