Skip to content

Add From for Hashed #21690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add From for Hashed #21690

wants to merge 1 commit into from
+6 −0

Conversation

@Shatur
Copy link
Contributor

@Shatur Shatur commented Oct 29, 2025 •
edited
Loading

Objective

  • Calling Hashed::new could be annoying if a function accepts it.

Solution

  • Add From impl to allow creating functions that accepts impl From<V>.

@Shatur Shatur requested a review from alice-i-cecile October 29, 2025 20:57
@Shatur Shatur added this to the 0.17.3 milestone Oct 29, 2025
@Shatur Shatur added the D-Trivial Nice and easy! A great choice to get started with Bevy label Oct 29, 2025
alice-i-cecile
alice-i-cecile reviewed Oct 29, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the appeal, but I'm not sure how much we want to let this diverge from the standard libraries impl. Do you have a concrete use case where this was helpful?

@alice-i-cecile alice-i-cecile added A-Utils Utility functions and types X-Contentious There are nontrivial implications that should be thought through S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Oct 29, 2025
@Shatur Shatur changed the title Add From for Hasher Add From for Hashed Oct 29, 2025
@Shatur
Copy link
Contributor Author

Shatur commented Oct 29, 2025

Sorry, I made a typo - it's Hashed wrapper, not Hasher 😅. The standard library doesn't include it, so we should be good.
My main motivation is to allow passing both V and Hashed<V> into my functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile left review comments

Assignees

No one assigned

Labels

A-Utils Utility functions and types D-Trivial Nice and easy! A great choice to get started with Bevy S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged X-Contentious There are nontrivial implications that should be thought through

Projects

None yet

Milestone

0.17.3

Development

Successfully merging this pull request may close these issues.

2 participants

@Shatur @alice-i-cecile