Skip to content

Conversation

@TheRawMeatball
Copy link
Member

No description provided.

@TheRawMeatball TheRawMeatball added A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible labels May 3, 2021
@alice-i-cecile alice-i-cecile added the C-Performance A change motivated by improving speed, memory usage or compile times label May 3, 2021
@Frizi
Copy link
Contributor

Frizi commented May 3, 2021

Shouldn't that variant be called par_map?

@TheRawMeatball TheRawMeatball changed the title Implement collecting for par_for_each Implement for par_iter and par_iter_mut on Query May 4, 2021
@TheRawMeatball
Copy link
Member Author

Alright, I rewrote the whole thing, and now it exposes par_iter methods on queries which let you use the parallel iterator interface in bevy_tasks.

@fopsdev fopsdev mentioned this pull request May 4, 2021
@cart cart added the S-Pre-Relicense This PR was made before Bevy added the Apache license. Cannot be merged or used for other work label Jul 23, 2021
@mockersf mockersf removed the S-Pre-Relicense This PR was made before Bevy added the Apache license. Cannot be merged or used for other work label Jul 24, 2021
@CGMossa
Copy link
Contributor

CGMossa commented Dec 15, 2021

I find myself in need of this PR. I have many places where I am filtering, and collecting based on query-data, and I wish to make these parallel executed.
If I can help with this PR, then that would be great.

@ManevilleF
Copy link
Contributor

What is the status of this MR ?

@TheRawMeatball
Copy link
Member Author

I'll fix it up eventually, though probably not that soon, given it's likely to break again.

@alice-i-cecile
Copy link
Member

@TheRawMeatball, are you interested in cleaning up the PR description and rebasing? Or should this wait on future work.

Totally fine if it's not a priority, but I'll add a Abandoned label so other folks know to pick up the work. This would be valuable, so I don't want to leave it sitting forever.

@TheRawMeatball TheRawMeatball added the S-Adopt-Me The original PR author has no intent to complete this work. Pick me up! label May 16, 2022
@ManevilleF
Copy link
Contributor

I think this PR could be very valuable, it can avoid using Mutex or RwLock when extracting parallelized block data

@mockersf
Copy link
Member

Query::par_iter and Query::par_iter_mut now exists

@mockersf mockersf closed this May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible C-Performance A change motivated by improving speed, memory usage or compile times S-Adopt-Me The original PR author has no intent to complete this work. Pick me up!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants