Use RenderStartup for meshlets.
#20210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriyDev
added
A-Rendering
atlv24
reviewed
Jul 20, 2025
Comment on lines
213
to
226
| ( | ||
| check_meshlet_features, | ||
| ( | ||
| ( | ||
| // This captures cluster_buffer_slots to create the resource manager. | ||
| move |mut commands: Commands, render_device: Res<RenderDevice>| { | ||
| commands.insert_resource(ResourceManager::new( | ||
| cluster_buffer_slots, | ||
| &render_device, | ||
| )); | ||
| }, | ||
| init_meshlet_pipelines, | ||
| ) | ||
| .chain(), | ||
| init_meshlet_mesh_manager, | ||
| ), | ||
| ) | ||
| .chain(), |
Contributor
There was a problem hiding this comment.
this is a pretty dreadful amount of nesting, can any of it be split into a let binding or something?
Contributor
Author
There was a problem hiding this comment.
I realized I could split off the closure into a variable and I think this makes it much more tolerable. There's still the same amount of nesting, but I think it's easier to see what's happening.
andriyDev
force-pushed
the
startup-meshlet
branch
from
ec77a33 to
01cf3f5
Compare
atlv24
reviewed
Jul 20, 2025
Comment on lines
+217
to
+227
| .add_systems( | ||
| RenderStartup, | ||
| ( | ||
| check_meshlet_features, | ||
| ( | ||
| (init_resource_manager_system, init_meshlet_pipelines).chain(), | ||
| init_meshlet_mesh_manager, | ||
| ), | ||
| ) | ||
| .chain(), | ||
| ) |
Contributor
There was a problem hiding this comment.
take this with an extremely large grain of salt, just wondering if something like this can help maybe? deliberately not a "suggestion"
.add_systems(
RenderStartup,
(
(check_meshlet_features, init_meshlet_mesh_manager).chain(),
(init_resource_manager_system, init_meshlet_pipelines).chain()
.after(check_meshlet_features),
)
)
atlv24
approved these changes
Jul 20, 2025
alice-i-cecile
approved these changes
Jul 20, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
RenderStartup.ResourceManagerto capture thecluster_buffer_slots.Testing
meshletexample and it behaves the same as main.