bevy_reflect: streamline generated FromReflect::from_reflect
#19906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Generated
from_reflect
methods use closures in a weird way, e.g.:The reason for this is because when
#[reflect(Default)]
is used, you instead get stuff like this:and the closure is necessary to contain the scope of the
?
. But the first case is more common.Helps with #19873.
Solution
Avoid the closure in the common case.
Testing
I used cargo expand to confirm the closures are no longer produced in the common case.
-Zmacro-stats
output tells me this reduces the size of theReflect
code produced forbevy_ui
by 0.5%.