Skip to content

Rename Timer::finished and Timer::paused to is_finished and is_paused #19386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 27, 2025
Merged

Rename Timer::finished and Timer::paused to is_finished and is_paused #19386

merged 4 commits into from
May 27, 2025

Conversation

@FlippinBerger
Copy link
Contributor

@FlippinBerger FlippinBerger commented May 26, 2025

Objective

Renames Timer::finished and Timer::paused to Timer::is_finished and Timer::is_paused to align the public APIs for Time, Timer, and Stopwatch.

Fixes #19110

mgi388
mgi388 suggested changes May 26, 2025
View reviewed changes
Copy link
Contributor

@mgi388 mgi388 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that there's no technical blocker, but the existing methods should remain and be marked as deprecated rather than being removed entirely.

@mgi388 mgi388 added D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Time Involves time keeping and reporting M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels May 27, 2025
@mockersf mockersf added this pull request to the merge queue May 27, 2025
Merged via the queue into bevyengine:main with commit a8376e9 May 27, 2025
44 checks passed
@FlippinBerger FlippinBerger deleted the timer-method-rename branch May 27, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mockersf mockersf mockersf approved these changes

+1 more reviewer

@mgi388 mgi388 mgi388 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Time Involves time keeping and reporting C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename Timer::paused to Timer::is_paused and Timer::finished to Timer::is_finished

3 participants

@FlippinBerger @mockersf @mgi388