-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Making so animation transition is able to handle multiple active animations! #18954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
@mweatherley @pcwalton Kindly review, would love this feature on 0.16.1. |
…e cant be based on graph due to reduplication of clips
Looks good overall and I like this change, and this is something I need myself. I have some comments however:
|
@Lunkentuss Makes sense |
@alice-i-cecile If possible can we perhaps add this to the next merge train? I would love to take the glue code from my project? |
This requires two approvals first; I'll ask around. I don't have the expertise with animation to review this myself. @Lunkentuss, if you're comfortable, we'd welcome a review from you however. |
Objective - Finished
In this PR I make it so AnimationTransitions component, actually has a concept called flows! Which will ease up the introduction of StateMachines for Animations
I also believe he shouldnt be limited by the idea of one sole "main" animation specially with the advent of layer through AnimationMasks. As the current implementation does
Solution
-In this case I make it so instead, of having the idea of one sole active animation, transitions actually has the ability of having multiple flows. Each flow having a one-to-one "main" animation. This will work nicely, with @pcwalton additive blends, and masks, and should mantain all the previous features of AnimationTransitions.