Skip to content

bevy_ecs: forward type_id in InfallibleSystemWrapper #18931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025
+4 −0
Merged

bevy_ecs: forward type_id in InfallibleSystemWrapper #18931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/bevy_ecs/src/system/schedule_system.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ impl<S: System<In = ()>> System for InfallibleSystemWrapper<S> {
self.0.name()
}

fn type_id(&self) -> core::any::TypeId {
Copy link
Contributor

@SpecificProtagonist SpecificProtagonist Apr 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fn type_id(&self) -> core::any::TypeId {
/// Type id of the wrapped system.
fn wrapped_type_id(&self) -> core::any::TypeId {

Let's not shadow <InfallibleSystemWrapper as Any>::type_id with a different meaning (previously using the same name was fine, as it always returned the same result).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we rename the method, I'd vote for system_type because not every System is a wrapper. It also aligns with SystemSet::system_type

self.0.type_id()
}

#[inline]
fn component_access(&self) -> &Access<ComponentId> {
self.0.component_access()
Expand Down