Skip to content

Don't restrict the scene viewer to loading assets from approved paths. #18828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025

Conversation

pcwalton
Copy link
Contributor

The purpose of the scene viewer is to load arbitrary glTF scenes, so it's inconvenient if they have to be moved into the Bevy assets directory first. Thus this patch switches the scene viewer to use UnapprovedPathMode::Allow.

The purpose of the scene viewer is to load arbitrary glTF scenes, so
it's inconvenient if they have to be moved into the Bevy assets
directory first. Thus this patch switches the scene viewer to use
`UnapprovedPathMode::Allow`.
@pcwalton pcwalton added A-Assets Load files from disk to use for things like images, models, and sounds C-Examples An addition or correction to our examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 13, 2025
@pcwalton pcwalton requested a review from cart April 13, 2025 08:55
@pcwalton pcwalton requested a review from alice-i-cecile April 13, 2025 08:55
Copy link
Contributor

@JMS55 JMS55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the slightly nicer wording @mockersf proposed.

Co-authored-by: François Mockers <francois.mockers@vleue.com>
@mockersf mockersf added this pull request to the merge queue Apr 14, 2025
Merged via the queue into bevyengine:main with commit 5e69518 Apr 14, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Examples An addition or correction to our examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants