-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Update shader_prepass, testbed_2d, and first_person_view_model examples to use children! macro #18270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
Hm, when clicking the link here I see a comparison which reports 17 screenshots in the unchanged category. Is there something I'm missing here? |
Yeah that's really odd. @mockersf, do you know what's up with that? |
234fdfa
to
bf367c5
Compare
@@ -226,20 +226,19 @@ mod text { | |||
Transform::from_translation(dest + Vec3::Z), | |||
anchor, | |||
StateScoped(super::Scene::Text), | |||
children![ | |||
( | |||
TextSpan::new(format!("{}, {}\n", anchor.x, anchor.y)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I resolved a merge conflict on these lines, I believe this line was the only delta but worth re-reviewing with a close eye.
Objective
Contributes to #18238
Updates the
shader_prepass
,testbed_2d
andfirst_person_view_model
examples to use thechildren!
macro. I wanted to keep the PR small but chose to do 3 examples since they were all limited in scopeSolution
Updates examples to use the Improved Spawning API merged in #17521
Testing
--features wayland
.Showcase
n/a
Migration Guide
n/a