Skip to content

Fix panic in benches caused by missing resources #16956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2024
Merged

Fix panic in benches caused by missing resources #16956

merged 1 commit into from
Dec 24, 2024

Conversation

@omaskery
Copy link
Contributor

@omaskery omaskery commented Dec 24, 2024

Objective

  • To fix the benches panicking on main

Solution

  • It appears that systems requiring access to a non-existing Res now causes a panic
  • Some of the benches run systems that access resources that have not been inserted into the world
  • I have made it so that those resources are inserted into the world

Testing

  • I ran all the ecs benches and they all run without panicking

@BenjaminBrienen BenjaminBrienen added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events C-Benchmarks Stress tests and benchmarks used to measure how fast things are S-Needs-Review Needs reviewer attention (from anyone!) to move forward D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Dec 24, 2024
@mockersf mockersf added this pull request to the merge queue Dec 24, 2024
Merged via the queue into bevyengine:main with commit a7ae080 Dec 24, 2024
34 checks passed
@omaskery omaskery deleted the stop-benchmarks-panicking-from-missing-resources branch December 24, 2024 21:28
pcwalton pushed a commit to pcwalton/bevy that referenced this pull request Dec 25, 2024
@omaskery @pcwalton
Fix panic in benches caused by missing resources (bevyengine#16956)
5974d96 
# Objective

- To fix the benches panicking on `main`

## Solution

- It appears that systems requiring access to a non-existing `Res` now
causes a panic
- Some of the benches run systems that access resources that have not
been inserted into the world
- I have made it so that those resources are inserted into the world

## Testing

- I ran all the ecs benches and they all run without panicking

Co-authored-by: Oliver Maskery <oliver@wellplayed.games>
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Jan 6, 2025
@omaskery @ecoskey
Fix panic in benches caused by missing resources (bevyengine#16956)
affda56 
# Objective

- To fix the benches panicking on `main`

## Solution

- It appears that systems requiring access to a non-existing `Res` now
causes a panic
- Some of the benches run systems that access resources that have not
been inserted into the world
- I have made it so that those resources are inserted into the world

## Testing

- I ran all the ecs benches and they all run without panicking

Co-authored-by: Oliver Maskery <oliver@wellplayed.games>
mrchantey pushed a commit to mrchantey/bevy that referenced this pull request Feb 4, 2025
@omaskery @mrchantey
Fix panic in benches caused by missing resources (bevyengine#16956)
5e6a2e8 
# Objective

- To fix the benches panicking on `main`

## Solution

- It appears that systems requiring access to a non-existing `Res` now
causes a panic
- Some of the benches run systems that access resources that have not
been inserted into the world
- I have made it so that those resources are inserted into the world

## Testing

- I ran all the ecs benches and they all run without panicking

Co-authored-by: Oliver Maskery <oliver@wellplayed.games>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mockersf mockersf mockersf approved these changes

+1 more reviewer

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-ECS Entities, components, systems, and events C-Benchmarks Stress tests and benchmarks used to measure how fast things are C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@omaskery @mockersf @BenjaminBrienen