Fix compile_fail compile fail
#16805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BD103
added
C-Bug
Member
Author
|
Alice previously approved this when it was part of #16770. I decided that fixing CI was too complicated for a single PR, so I split it up into tasks in #16801. |
MrGVSV
approved these changes
Dec 13, 2024
MrGVSV
added
the
S-Ready-For-Final-Review
SpecificProtagonist
approved these changes
Dec 16, 2024
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective - Fixes bevyengine#16802, part of bevyengine#16801, extracted from bevyengine#16770. ## Solution - Fix `compile_fail_utils`'s example test so that it now compiles. - Bless the results, which were outdated. ## Testing - `cd tools/compile_fail_utils && cargo check --all-targets` - `cd tools/compile_fail_utils && cargo test --test example`
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
# Objective - Fixes bevyengine#16802, part of bevyengine#16801, extracted from bevyengine#16770. ## Solution - Fix `compile_fail_utils`'s example test so that it now compiles. - Bless the results, which were outdated. ## Testing - `cd tools/compile_fail_utils && cargo check --all-targets` - `cd tools/compile_fail_utils && cargo test --test example`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
compile_fail_utilsno longer compiles #16802, part of Add benchmarks and compile fail tests back to workspace #16801, extracted from Addcompile_fail_utils, compile fail tests, and benchmarks to Cargo workspace #16770.Solution
compile_fail_utils's example test so that it now compiles.Testing
cd tools/compile_fail_utils && cargo check --all-targetscd tools/compile_fail_utils && cargo test --test example