Ignore the 'instant is unmaintained' advisory. - #16763
Merged
Merged
Conversation
This change has already been made upstream in the notify-types crate, but it's up to the maintainer to publish the crate. There is nothing for us to do.
BD103
added
D-Trivial
alice-i-cecile
approved these changes
Dec 11, 2024
alice-i-cecile
left a comment
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
Yeah, I don't think this is a useful warning at this point. Low-severity and unactionable.
alice-i-cecile
added
S-Ready-For-Final-Review
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective - Hides bevyengine#16477. ## Solution Add the advisory ID to the list of ignored advisories. The notify-types crate has already been switched to web-time upstream, but it's up to the maintainer to publish the crate. There is nothing for us to do, so better to just ignore it so we don't ignore this CI check anymore (and mistakenly miss new advisories). ## Testing - Tested locally.
SilentSpaceTraveller
added a commit
to SilentSpaceTraveller/bevy
that referenced
this pull request
Feb 8, 2025
Remove temporary silence introduced in bevyengine#16763 and upgrade version of `notify-debouncer-full` to remove transitive dependency on `instant` crate. Fix bevyengine#16477.
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 17, 2025
…gine#17741) Fix bevyengine#16477. - Remove temporary silence introduced in bevyengine#16763 - bump version of `notify-debouncer-full` to remove transitive dependency on `instant` crate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
instantcrate. #16477.Solution
Add the advisory ID to the list of ignored advisories.
The notify-types crate has already been switched to web-time upstream, but it's up to the maintainer to publish the crate. There is nothing for us to do, so better to just ignore it so we don't ignore this CI check anymore (and mistakenly miss new advisories).
Testing