-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Specialized UI transform #16615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ickshonpe
wants to merge
95
commits into
bevyengine:main
Choose a base branch
from
ickshonpe:node-global-transform
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Specialized UI transform #16615
Changes from all commits
Commits
Show all changes
95 commits
Select commit
Hold shift + click to select a range
76c0480
* Added a `transform: Transform` field to `Node`.
ickshonpe 6847c51
Fixed overflow_debug example
ickshonpe ff39bd4
Use logical units for `Node`'s translation
ickshonpe 96465d1
Merge branch 'main' into node-global-transform
ickshonpe f6a3dc8
fix for ambiguity detection
ickshonpe 447cea6
Merge branch 'node-global-transform' of https://github.com/ickshonpe/…
ickshonpe 3dc5c2a
Merge branch 'main' into node-global-transform
ickshonpe 67e8315
Fixes for merge
ickshonpe 10833bf
Changed the `Val::resolve` method to always return always return a va…
ickshonpe e5a59f1
Merge branch 'main' into node-global-transform
ickshonpe 78ddbf3
Merge branch 'main' into node-global-transform
ickshonpe 78a9972
Split up the `Transform` field into separate fields for translation, …
ickshonpe 81d9433
Made new `Node` fields `pub`.
ickshonpe abeda2b
Updated layout to use new transform fields.
ickshonpe 2c98ce5
Fixed examples
ickshonpe 54fb3ac
negate rotation before applying it in layout updates
ickshonpe 8825583
Added `TransformedNode` type
ickshonpe 40c51b1
Merge branch 'node-global-transform' into node-global-transform-trans…
ickshonpe 085316f
Addeded `transform: Affine2` field to `ComputedNode`.
ickshonpe 0566eeb
Updated remaining rendering modules
ickshonpe 3dfcdfc
Fixed update module
ickshonpe 6c74428
Fixed accessibility module
ickshonpe 1441201
fixed picking
ickshonpe 7243867
Updated doc comments
ickshonpe 96ddbc8
Added contains_point helper functions to ComputedNode
ickshonpe 8112c79
Removed unused
ickshonpe 430b657
updated ComputedNode::transform doc comment
ickshonpe 1f3d3af
Fixed `focus` module.
ickshonpe bcb8757
Changed picking_backend to check mouse over recursively
ickshonpe bd59b49
Removed comments.
ickshonpe 09879ec
Updated `ui_root_node_should_act_like_position_absolute` test
ickshonpe af637c4
Removed unused
ickshonpe 7f5f998
Added `UiVec`, `UiTransform`, `UiGlobalTransform` types.
ickshonpe ebeaed2
Update `UiGlobalTransform` in ui_layout_system
ickshonpe 8def248
Update everything to use new UI transform components
ickshonpe 59492df
Merge branch 'val-physical-resolve' into node-ui-transform
ickshonpe 0c4ef87
Added resolve method to `UiVec`
ickshonpe 129c279
Use resolve function in ui_layout_system
ickshonpe 27c0718
Fixed spelling mistake
ickshonpe 4c6f9c6
Fixed UI debug overlay extraction
ickshonpe a42e295
Fixed `UiVec` attributes
ickshonpe fa613c3
Use object-centered coordinates for uinodes instead of inconsistantly…
ickshonpe 14fe83a
Changed std import for core
ickshonpe 60ebe6d
Fixed redundant explicit link target
ickshonpe 8fa6db5
Renamed `mouse_over` to `cursor_over`
ickshonpe 5ff2495
Added draft release note
ickshonpe 25cdfaa
Fix for md lint
ickshonpe 1069293
md fix
ickshonpe dc73857
Added `resolve_clip_rect` helper method to `ComputedNode.
ickshonpe 447844e
Moved `clip_check_recursive` to `picking_backend` module.
ickshonpe a289ca2
Clean up picking_backend
ickshonpe c1e9a6b
Removed unneeded variable
ickshonpe 04933ec
Removed unused import
ickshonpe 4f28bc1
Fixed `resolve_clip_rect`, Rect::from_center_size takes a size, not a…
ickshonpe 8318286
Made `UiGlobalTransform`'s inner value private.
ickshonpe e32cdb1
Fixed accessor in debug_overlay
ickshonpe b9440e2
Added migration guide
ickshonpe 2ac47f5
Added trailing line to migration guide.
ickshonpe e91c901
updated migration guide
ickshonpe c6726fa
Fix migration-guide
ickshonpe 836d8c6
Merge branch 'main' into node-global-transform
ickshonpe b71f014
Merge branch 'main' into node-global-transform
ickshonpe fb9fc0f
Added `ui_transform` example
ickshonpe ff42405
update example
ickshonpe 6f06089
use children! in example
ickshonpe 9495d21
rotate by positive angle
ickshonpe 36b8953
rotate text in example
ickshonpe a532f32
Merge branch 'node-global-transform' of https://github.com/ickshonpe/…
ickshonpe 3a0a499
Merge branch 'main' into node-global-transform
ickshonpe 306d6f1
moved ui_transform to label's parents in example
ickshonpe 7449a32
apply node + UiTransform's translation together
ickshonpe 6674cc7
Merge branch 'node-global-transform' of https://github.com/ickshonpe/…
ickshonpe 93f3ce8
Renamed `UiVec` to `Val2`, added doc comment.
ickshonpe 94714e6
Fixed unresolved doc links
ickshonpe 5882696
Removed default on unit struct
ickshonpe 84b1663
Merge branch 'main' into node-global-transform
ickshonpe c5afa14
Merge branch 'main' into node-global-transform
ickshonpe 67b4735
Merge branch 'main' into node-global-transform
ickshonpe 05e874a
Removed useless conversion
ickshonpe 7ede048
Merge branch 'main' into node-global-transform
ickshonpe b4469ea
Fixed unused imports left over after merge.
ickshonpe 1218ad9
Changed `rect_size` to a `Vec2 in `prepare_uinodes`
ickshonpe e4c1f44
Removed unused import.
ickshonpe 0c76276
Fixed unused imports left over after merge.
ickshonpe be00de2
Updated gradients module
ickshonpe c261a07
Changed `UiTransform::rotation` to `Rot2`
ickshonpe 3d84a36
Fixed compute_affine method
ickshonpe 280cb3e
Merge branch 'node-global-transform' of https://github.com/ickshonpe/…
ickshonpe ee33460
Fixed `full_ui` example
ickshonpe 0c5ca2a
Fixed backticks in comment.
ickshonpe 92d3b1a
Replaced `from_angle` fns with a single from rotation function taking…
ickshonpe f0a582e
Updated `ui_transform` example
ickshonpe 6b633e3
Updated migration guide
ickshonpe ffd6914
Added migration guide for relative cursor position
ickshonpe 7eddd04
Fixes for migration guide lints
ickshonpe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you justified this change anywhere. I'm not against it, but why?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's part of the changes to replace top-left-aligned coordinates and consistantly use only object-centered coordinates.
Definitely some users find having the origin at the top-left more intuitive though, if people really hate it I'm not against changing it back in this case.