feat: support for clip children on windows #16545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
BenjaminBrienen
approved these changes
Nov 28, 2024
BenjaminBrienen
added
C-Feature
jf908
approved these changes
Jan 7, 2025
Contributor
jf908
left a comment
jf908
left a comment
There was a problem hiding this comment.
Thought I would review this because of an interest in webview stuff. Tested and it works, example here: https://github.com/jf908/bevy-webview-test.
Small doc suggestion but nothing blocking, lgtm.
P.S. It took me ages to find the Microsoft documentation which explains this option, it's here: https://learn.microsoft.com/en-us/windows/win32/winmsg/window-features#clipping
Co-authored-by: jf908 <jf908@users.noreply.github.com>
BenjaminBrienen
approved these changes
Jan 8, 2025
BenjaminBrienen
approved these changes
Jan 13, 2025
BenjaminBrienen
added
S-Ready-For-Final-Review
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
# Objective Support the parametrization of the WS_CLIPCHILDREN style on Windows. Fixes bevyengine#16544 ## Solution Added a window configuration in bevy_winit to control the usage of the WS_CLIPCHILDREN style. ## Testing - Did you test these changes? If so, how? I did. I was able to create a Wry Webview with a transparent HTML document and was also able to see my Bevy scene behind the webview elements. - Are there any parts that need more testing? I don't believe so. I assume the option is extensively tested within winit itself. - How can other people (reviewers) test your changes? Is there anything specific they need to know? Test repositiory [here](https://github.com/nicholasc/bevy_wry_test). Bevy's path will need to be updated in the Cargo.toml - If relevant, what platforms did you test these changes on, and are there any important ones you can't test? This is a Windows specific issue. Should be tested accordingly. --------- Co-authored-by: jf908 <jf908@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Support the parametrization of the WS_CLIPCHILDREN style on Windows.
Fixes #16544
Solution
Added a window configuration in bevy_winit to control the usage of the WS_CLIPCHILDREN style.
Testing
Did you test these changes? If so, how?
I did. I was able to create a Wry Webview with a transparent HTML document and was also able to see my Bevy scene behind the webview elements.
Are there any parts that need more testing?
I don't believe so. I assume the option is extensively tested within winit itself.
How can other people (reviewers) test your changes? Is there anything specific they need to know?
Test repositiory here. Bevy's path will need to be updated in the Cargo.toml
If relevant, what platforms did you test these changes on, and are there any important ones you can't test?
This is a Windows specific issue. Should be tested accordingly.