Assorted small small style refactors #16205
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
BenjaminBrienen
added
C-Code-Quality
alice-i-cecile
changed the title
|
Can you justify why these changes are good? One sentence is fine. |
alice-i-cecile
added
D-Trivial
mockersf
reviewed
Nov 5, 2024
| @@ -95,8 +95,7 @@ impl RelativeCursorPosition { | |||
| /// A helper function to check if the mouse is over the node | |||
| pub fn mouse_over(&self) -> bool { | |||
| self.normalized | |||
| .map(|position| self.normalized_visible_node_rect.contains(position)) | |||
| .unwrap_or(false) | |||
| .map_or(false, |position| self.normalized_visible_node_rect.contains(position)) | |||
There was a problem hiding this comment.
there's some distaste amongst some contributors (me included) with using map_or as it's harder to read because it put the "or" case first
ickshonpe
reviewed
Nov 5, 2024
Comment on lines
27
to
+36
| for child in children { | ||
| let values = text_reader | ||
| .iter(child) | ||
| .map(|(_, _, text, _, _)| text.into()) | ||
| .map(|(_, _, text, _, _)| text.to_string()) | ||
| .collect::<Vec<String>>(); | ||
| if !values.is_empty() { | ||
| name = Some(values.join(" ")); | ||
| name = Some(values.join(" ").into_boxed_str()); | ||
| } | ||
| } | ||
| name.map(String::into_boxed_str) | ||
| name |
There was a problem hiding this comment.
Your changes seem sensible, but this function doesn't look right. Even if it's correct, it could iterate children backwards and short circuit return the first success rather than collecting and throwing away all these intermediate vecs?
|
Looks like this should be closed in favor of #16250 as it's a subset of the same changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
we can directly assign the result of the loop to name
text.into() can be changing the type conversion method to be more explicit.
Testing
Showcase
While a showcase should aim to be brief and digestible, you can use a toggleable section to save space on longer showcases:
Click to view showcase
Migration Guide