Skip to content

Using Cas instead of CAS #14341 #14357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 20, 2024
Merged

Using Cas instead of CAS #14341 #14357

merged 6 commits into from
Jul 20, 2024

Conversation

Cioraz
Copy link
Contributor

@Cioraz Cioraz commented Jul 17, 2024 •
edited
Loading

Objective

Solution

  • Simple replace

@mockersf
Copy link
Member

this doesn't close #14341, there are other types using CAS instead of Cas: found DenoiseCAS, CASUniform, CASNode, CASPipeline, CASPipelineKey, ViewCASPipeline with a quick search.

Could you also change those?

mockersf
mockersf reviewed Jul 17, 2024
View reviewed changes
crates/bevy_core_pipeline/src/contrast_adaptive_sharpening/mod.rs Outdated
pub use node::CasNode;

/// Applies a contrast adaptive sharpening (CAS) filter to the camera.
/// Applies a contrast adaptive sharpening (Cas) filter to the camera.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in doc it should stay CAS

@mockersf mockersf self-requested a review July 17, 2024 09:46
janhohenheim
janhohenheim suggested changes Jul 17, 2024
View reviewed changes
@janhohenheim janhohenheim added D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide X-Uncontroversial This work is generally agreed upon S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Jul 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy?
It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

@janhohenheim janhohenheim added this to the 0.15 milestone Jul 17, 2024
@mockersf @janhohenheim
Update crates/bevy_core_pipeline/src/contrast_adaptive_sharpening/mod.rs
f600caf 
Co-authored-by: Jan Hohenheim <jan@hohenheim.ch>
@mockersf mockersf enabled auto-merge July 20, 2024 18:03
@mockersf mockersf added this pull request to the merge queue Jul 20, 2024
Merged via the queue into bevyengine:main with commit 2158f3d Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

+1 more reviewer

@janhohenheim janhohenheim janhohenheim requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.

Types related to Contrast Adaptive Sharpening should be Cas* instead of CAS*
3 participants
@Cioraz @mockersf @janhohenheim