Skip to content

Conversation

BD103
Copy link
Member

@BD103 BD103 commented May 4, 2024

Objective

Solution

  • Use workspace inheritance for uncontroversial properties, specifically: edition, license, rust-version, homepage, and repository.
  • In the future we can inherit dependencies or the Bevy version, but those caused Workspace inheritance #6089 to be marked as controversial so I'm leaving them for the future.

Changelog

  • Crates' Cargo.tomls now inherit certain properties from the workspace.

BD103 added 6 commits May 4, 2024 17:25
The documentation link would be different for each individual crate, so inheriting it does not make sense.
This is in a separate commit because I'm not sure if these crates should even have this metadata in the first place.
@BD103 BD103 added C-Code-Quality A section of code that is hard to understand or change A-Cross-Cutting Impacts the entire engine labels May 4, 2024
@BD103
Copy link
Member Author

BD103 commented May 5, 2024

Nevermind, turns out workspace inheritance breaks compile fail tests (since they are not included in the workspace). Closing this unless I can think of a solution.

@BD103 BD103 closed this May 5, 2024
@BD103 BD103 deleted the workspace-inheritence branch May 5, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Cross-Cutting Impacts the entire engine C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant