Skip to content

Use WireframeColor to override global color #13034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

IceSentry
Copy link
Contributor

Objective

  • The docs says the WireframeColor is supposed to override the default global color but it doesn't.

Solution

  • Use WireframeColor to override global color like docs said it was supposed to do.
  • Updated the example to document this feature
  • I also took the opportunity to clean up the code a bit

Fixes #13032

@IceSentry IceSentry added A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior labels Apr 19, 2024
@IceSentry IceSentry added this to the 0.14 milestone Apr 19, 2024
@alice-i-cecile
Copy link
Member

@galop1n your review would be welcome here if you feel comfortable taking a peek at the internals.

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 20, 2024
@mockersf mockersf added this pull request to the merge queue Apr 20, 2024
Merged via the queue into bevyengine:main with commit 8403c41 Apr 20, 2024
@IceSentry IceSentry deleted the global-wireframe-color branch April 22, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WireFrameColor component ignored
3 participants