Skip to content

Comments

Remove APIs deprecated in 0.13#11974

Merged
alice-i-cecile merged 9 commits intobevyengine:mainfrom
james7132:0.13-deprecated-removal
Feb 19, 2024
Merged

Remove APIs deprecated in 0.13#11974
alice-i-cecile merged 9 commits intobevyengine:mainfrom
james7132:0.13-deprecated-removal

Conversation

@james7132
Copy link
Member

@james7132 james7132 commented Feb 19, 2024

Objective

We deprecated quite a few APIs in 0.13. 0.13 has shipped already. It should be OK to remove them in 0.14's release. Fixes #4059. Fixes #9011.

Solution

Remove them.

@james7132 james7132 added A-Rendering Drawing game state to the screen A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Feb 19, 2024
@james7132 james7132 added this to the 0.14 milestone Feb 19, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 19, 2024
@james7132
Copy link
Member Author

@alice-i-cecile mind taking a look at the updates to the Query doc? I needed to rewrite some of it to accomodate the removal of Query::for_each.

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look solid, thanks for the ping :)

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 19, 2024
Merged via the queue into bevyengine:main with commit bc82749 Feb 19, 2024
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
# Objective
We deprecated quite a few APIs in 0.13. 0.13 has shipped already. It
should be OK to remove them in 0.14's release. Fixes bevyengine#4059. Fixes bevyengine#9011.

## Solution
Remove them.
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
# Objective
We deprecated quite a few APIs in 0.13. 0.13 has shipped already. It
should be OK to remove them in 0.14's release. Fixes bevyengine#4059. Fixes bevyengine#9011.

## Solution
Remove them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ECS Entities, components, systems, and events A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Query::get_component should mention that the compenent must be part of the query Remove for_each and for_each_mut APIs

4 participants