Skip to content

Remove unused namespace declarations #10965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2023
Merged

Remove unused namespace declarations #10965

merged 1 commit into from
Dec 13, 2023

Conversation

tygyh
Copy link
Contributor

@tygyh tygyh commented Dec 13, 2023

Objective

  • Shorten the list of namespaces in the logo.

Solution

  • Remove the unused namespace declarations.

@matiqo15 matiqo15 added the A-Meta About the project itself label Dec 13, 2023
@alice-i-cecile
Copy link
Member

Looks like this is a change to the .svg file itself. Could you link to the line that was removed please? Github's UI really doesn't like displaying a sensible diff for this.

@tygyh
Copy link
Contributor Author

tygyh commented Dec 13, 2023

´xmlns:svg="http://www.w3.org/2000/svg"´ is the code which was removed. It was line 13 in the logo files and line 16 in the icon file.

@matiqo15 matiqo15 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 13, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 13, 2023
Merged via the queue into bevyengine:main with commit 0159df3 Dec 13, 2023
@tygyh tygyh deleted the Remove-unused-namespace-declarations branch December 15, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@matiqo15 matiqo15 matiqo15 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
A-Meta About the project itself S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tygyh @alice-i-cecile @matiqo15