Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor function update_accessibility_nodes #10911

Merged
merged 11 commits into from
Dec 10, 2023
Merged

Refactor function update_accessibility_nodes #10911

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d0a9459
Add TODOs
Nilirad Dec 8, 2023
20cd918
Add early return conditions
Nilirad Dec 8, 2023
4879add
Inline `should_run` variable
Nilirad Dec 8, 2023
98f10d5
Move `if primary_window.focused` after loop
Nilirad Dec 8, 2023
af2f14d
Remove `name` variable
Nilirad Dec 8, 2023
a23f8a9
Optimize and inline `focus_id`
Nilirad Dec 8, 2023
fc4ea59
Rename variables
Nilirad Dec 8, 2023
e26d541
Extract variables
Nilirad Dec 8, 2023
b6fc5a6
Extract functions
Nilirad Dec 8, 2023
2a026a5
Refactor `queue_node_for_update`
Nilirad Dec 8, 2023
bab6580
Appease Clippy
Nilirad Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Inline should_run variable
  • Loading branch information
@Nilirad
Nilirad committed Dec 8, 2023
commit 4879add15b1c724ffc68b754acb4d51b32aeabc5
4 changes: 1 addition & 3 deletions crates/bevy_winit/src/accessibility.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,7 @@ fn update_accessibility_nodes(
let Some(adapter) = adapters.get(&primary_window_id) else {
return;
};
// TODO: Inline variable
let should_run = focus.is_changed() || !nodes.is_empty();
if should_run {
if focus.is_changed() || !nodes.is_empty() {
// TODO: Extract into function
adapter.update_if_active(|| {
let mut to_update = vec![];
Expand Down