Skip to content

Expose rodio's Source and Sample trait in bevy_audio #5876

Description

@harudagondi

What problem does this solve or what need does it fill?

In bevy_audio, Decodable::Decoder requires rodio::source::Source and Decodable::DecoderItem requires rodio::Sample, which in turn, requires cpal::Sample.

Therefore, users who want to define their own Decodable types must manually import rodio and cpal.

What solution would you like?

  • pub use rodio::source::Source, rodio::Sample, and cpal::Sample.

What alternative(s) have you considered?

  • Just make the users manually import the required dependencies. This will cause problems when the user wants to use a different version of rodio and cpal for other purposes.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-AudioSounds playback and modificationC-FeatureA new feature, making something new possibleD-TrivialNice and easy! A great choice to get started with Bevy

    Type

    No type

    Projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions