KeyCode::Plus (Minus) not working correctly

[Halcom1979]

Bevy version 0.5
Windows 10

What you did

Used following system to zoom in and out. KeyCode::PageDown and PageUp are working. KeyCode::Minus is only working with the normal Minus key, not the one from the NumPad. Also KeyCode::Plus does not work with Plus key or NumPad Plus key. I use a german Keyboard layout.

fn zoom(keyboard_input: Res<Input<KeyCode>>, mut query: Query<(&mut Transform), With<Camera>>) {
    let mut dir = 0.0;
    if keyboard_input.pressed(KeyCode::PageDown) || keyboard_input.pressed(KeyCode::Plus) {
        dir = -0.7;
    }

    if keyboard_input.pressed(KeyCode::PageUp) || keyboard_input.pressed(KeyCode::Minus) {
        dir = 0.7;
    }

    if dir != 0.0 {
        if let Ok(mut transform) = query.single_mut() {
            transform.scale.x += dir * TIME_STEP;
            transform.scale.y += dir * TIME_STEP;
            transform.scale.x = transform.scale.x.clamp(0.5, 2.0);
            transform.scale.y = transform.scale.y.clamp(0.5, 2.0);
        }
    }

    if keyboard_input.pressed(KeyCode::End) {
        if let Ok(mut transform) = query.single_mut() {
            transform.scale.x = 1.0;
            transform.scale.y = 1.0;
        }
    }
}

What you expected to happen

Korrect key recognition.

What actually happened

No or not all key recognitions.

Additional information

Used german Keyboard layout.

Any additional information you would like to add such as screenshots, logs, etc.

[bjorn3]

You need KeyCode::NumpadAdd and KeyCode::NumpadSubstract for the keypad + and -.

bevy/crates/bevy_input/src/keyboard.rs

Line 161 in 38c7d5e

NumpadAdd,

and

bevy/crates/bevy_input/src/keyboard.rs

Line 213 in 38c7d5e

NumpadSubtract,

[Halcom1979]

I thanks for the points to KeyCode::NumpadAdd and KeyCode::NumpadSubstract. I overread them in my search for NumpadMinus and NumpadPlus.

But the main Problem with KeyCode::Plus does not work keeps open.

[bjorn3]

While the "regular" + and the numpad + represent the same character, they are not the same key and as such don't have the same keycode. Some programs do distinguish between the two. The same applies for all numpad keys. For example in blender the numpad numbers are used to change viewport orientation, while the regular numbers are used for entering real numbers.

[manokara]

Also KeyCode::Plus does not work with Plus key or NumPad Plus key. I use a german Keyboard layout.

From what I've seen, Plus is a primary keycode in german layouts - as in, you don't need to use any modifiers to type it, unlike US-like layouts where it's Shift + Equals - and = is a secondary keycode. There might be a chance that the input system is not picking up on layout differences and KeyCode::Plus is the backtick key? It does work if you switch to a US keyboard layout, right?

[Halcom1979]

I made a minimum workable example to confirm that KeyCode::Plus does not work for me.

use bevy::prelude::*;

fn main() {
    App::build()
        .add_plugins(DefaultPlugins)
        .add_system(test_key.system())
        .run();
}

fn test_key(keyboard_input: Res<Input<KeyCode>>) {
    if keyboard_input.pressed(KeyCode::Plus) {
        println!("KeyCode::Plus pressed!");
    }
}

And for me it does not work with german or english keyboard layout.

[cart]

Can you run the keyboard_input_events example, press the key that you're trying to detect, and then share what key name is printed to your console?

[Halcom1979]

I found a example and get it to run (after some compile errors). It seems there are a lot of keys that doesnt work:

Plus: KeyboardInput { scan_code: 27, key_code: Some(Equals), state: Released }
ö: KeyboardInput { scan_code: 39, key_code: None, state: Released }
ä: KeyboardInput { scan_code: 40, key_code: None, state: Released }
#: KeyboardInput { scan_code: 43, key_code: None, state: Released }
´: KeyboardInput { scan_code: 13, key_code: None, state: Released }
ß: KeyboardInput { scan_code: 12, key_code: None, state: Released }
^: KeyboardInput { scan_code: 41, key_code: None, state: Released }

[bjorn3]

Which keyboard layout did you configure on your system?

[Halcom1979]

Default German Layout, on German Windows 10

[bjorn3]

For Plus I think the issue is https://github.com/rust-windowing/winit/blob/438d286fd5d5b0c007836bf88766ce920576c73c/src/platform_impl/windows/event.rs#L312 mapping VK_OEM_PLUS to Equals. For ^ the mapping is missing. For the rest there is simply no key code.

[hamdav]

I also see plus being mapped to KeyCode::Equals using a macbook pro laptop with a swedish keyboard. We also have Plus as a primary keycode.