Skip to content

PropagateStop prevents self from having component #21620

@ekwoka

Description

@ekwoka

The PropagateStop documentation (here) states "Children will not inherit the component."

This implies that the component with PropagateStop should have it.

This appears to not be the case. Based on reading the source, it seems to remove the value on itself.

The tests also do not test whether the propagated component arrives on the holder of PropagateStop, so at a minimum this appears to be a lapse (regardless of which of the behaviors is actually correct).

Is the Documentation Correct? That a PropagateStop as a child of Propagate SHOULD have the inherited C on it?

Looking Closer and updating tests, it seems that maybe even PropagateOver doesn't work at all.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-ECSEntities, components, systems, and eventsC-BugAn unexpected or incorrect behaviorS-Needs-ReviewNeeds reviewer attention (from anyone!) to move forwardX-ContentiousThere are nontrivial implications that should be thought through

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions