Skip to content

Can't use custom trigger type with default runner #21441

@PhaestusFox

Description

@PhaestusFox

What problem does this solve or what need does it fill?

In the 0.17 update post, it said you can make custom trigger types. While technically true, because the increment_trigger_id is pub(crate) and this needs to be called for the default runner to execute a trigger, you will need to make a custom runner for them, and so it is functionally impossible to use app.add_observer() with a custom trigger type since this will use the default runner.

What solution would you like?

make a way to call world.as_unsafe_world_cell().increment_trigger_id(); with the defered world passed to the trigger trait. So they can work with the default observer.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-ECSEntities, components, systems, and eventsC-BugAn unexpected or incorrect behaviorS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions