Skip to content

Item and fetch should be moved to QueryData from WorldQuery #17662

@alice-i-cecile

Description

@alice-i-cecile

It's kind of weird that QueryFilters even have an Item. I think it's mostly because they used to be a single trait, and the change to separate them tried to minimize changes.

Would be more clear if we moved Item and fetch from WorldQuery to QueryData, and then did all the filtering in filter_fetch? (Not in this PR, of course.) It doesn't look like fetch is ever called on a QueryFilter outside its own implementation, so that might work.

Originally posted by @chescock in #17654 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-ECSEntities, components, systems, and eventsC-Code-QualityA section of code that is hard to understand or changeD-ModestA "normal" level of difficulty; suitable for simple features or challenging fixesS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!X-UncontroversialThis work is generally agreed upon

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions