Skip to content

WireframeMaterial and Wireframe2dMaterial don't derive Reflect #17474

Open
@anlumo

Description

@anlumo

What problem does this solve or what need does it fill?

There are three types implementing Material in bevy:

  • StandardMaterial
  • ExtendedMaterial
  • WireframeMaterial

The former two implement Reflect, while the latter does not. I think this is an oversight.

The same is true for Material2d:

  • ColorMaterial derives Reflect, while
  • Wireframe2dMaterial does not.

What solution would you like?

Since the fields of WireframeMaterial and Wireframe2dMaterial are rather trivial, a simple #[derive(Reflect)] should be enough, mirroring StandardMaterial and ColorMaterial.

What alternative(s) have you considered?

Just don't support WireframeMaterial, but I think it'd be good for debugging purposes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-RenderingDrawing game state to the screenC-UsabilityA targeted quality-of-life change that makes Bevy easier to useD-TrivialNice and easy! A great choice to get started with BevyS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions