Replies: 6 comments 16 replies
-
Regardless of the decision, I'd like to see a consistency pass on the code base for this :) It's messy, and slightly increases the friction for contributors. |
Beta Was this translation helpful? Give feedback.
-
I'm for Something like:
Would look neat, but it needs to be only applicable to systems and should have a reason to exist. |
Beta Was this translation helpful? Give feedback.
-
By not using the Until then, the |
Beta Was this translation helpful? Give feedback.
-
I'm holding all my system functions inside impl of the struct CustomPlugin. Then I'm calling them inside impl Plugin for CustomPlugin. I never have systems outside of a impl scope. That does not feel like distinct enough sometimes. |
Beta Was this translation helpful? Give feedback.
-
_system prefix feels kinda forced and not natural. System is basically just a function, defined by its arguments. I think division by system/non-system functions should be done on the structural level, let's say functions in one mod, real systems in another. |
Beta Was this translation helpful? Give feedback.
-
I think calling |
Beta Was this translation helpful? Give feedback.
-
While I have an opinion on the subject (NO!), and there has already been a few polls on discord, what really bothers me is the lack of uniformity in the doc and examples, so I would like to have a decision that we can document and refer to.
So... here it is, a totally fair poll. Also, @cart vote probably counts around 9000:
_system
suffix_system
suffix to know my system is a system because indicating a function type by it's name is the bestBeta Was this translation helpful? Give feedback.
All reactions