Updates from master by amlanc1 · Pull Request #515 · bcgov/jasper

amlanc1 · 2025-09-17T17:04:15Z

Pull Request for JIRA Ticket: ----put ticket number here----

Issue ticket number and link

Include the JIRA ticket # and link here

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test A
Test B

Test Configuration:
If applicable

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

Documentation References

Put any doc references here

Co-authored-by: Ronaldo Macapobre <rmacapob@gov.bc.ca>

fix: add missing courtlist request mapping

* - Change Civil documents dropdown to show categories instead of doc types - Update category names to start with capital letter and remaining characters in lower case - Show Document Type in Scheduled Documents under Court List page - Use issueDsc instead of issueTypeDesc to show the more appropriate value * - Fix failing unit tests - Fix bug when deleting documents from binder --------- Co-authored-by: Ronaldo Macapobre <rmacapob@gov.bc.ca>

JASPER 577: Nutrient updates

* - Add S3 module to include certificate S3 bucket that will have the global bundle PEM file - Create S3Service to isolate logic that uses AWS SDK implementation - Update to try to connect to AWS Mongo Db * Comment out seeder and hangfire for now * Remove Hangfire setup * Pass the settings to the client * debug * Download the PEM file as part of the Dockerfile process * More logs * Revert changes and cleanup * Revert * Disable hangfire for now * Move DEFAULT_USERS as env variable instead of secret so it can be parsed as a JSON string during seeding process. * Add --no-install-recommends as suggested by SonarCloud * Fix SonarCloud warning --------- Co-authored-by: Ronaldo Macapobre <rmacapob@gov.bc.ca>

jasper-121 add access request page with basic api to allow saving new…

--- updated-dependencies: - dependency-name: GdPicture.API dependency-version: 14.3.14 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [uuid](https://github.com/uuidjs/uuid) from 11.1.0 to 12.0.0. - [Release notes](https://github.com/uuidjs/uuid/releases) - [Changelog](https://github.com/uuidjs/uuid/blob/main/CHANGELOG.md) - [Commits](uuidjs/uuid@v11.1.0...v12.0.0) --- updated-dependencies: - dependency-name: uuid dependency-version: 12.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

* - Change Civil documents dropdown to show categories instead of doc types - Update category names to start with capital letter and remaining characters in lower case - Show Document Type in Scheduled Documents under Court List page - Use issueDsc instead of issueTypeDesc to show the more appropriate value * - Fix failing unit tests - Fix bug when deleting documents from binder * - Calculate Scheduled documents for Civil Case Details - Programatically rename CSR to Court Summary * Add toLowerCase() consistency and better checking. --------- Co-authored-by: Ronaldo Macapobre <rmacapob@gov.bc.ca>

…-14.3.14 Bump GdPicture.API from 14.3.13 to 14.3.14

Bumps the all-actions group with 1 update: [aws-actions/configure-aws-credentials](https://github.com/aws-actions/configure-aws-credentials). Updates `aws-actions/configure-aws-credentials` from 4 to 5 - [Release notes](https://github.com/aws-actions/configure-aws-credentials/releases) - [Changelog](https://github.com/aws-actions/configure-aws-credentials/blob/main/CHANGELOG.md) - [Commits](aws-actions/configure-aws-credentials@v4...v5) --- updated-dependencies: - dependency-name: aws-actions/configure-aws-credentials dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: all-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…2.0.0 build(deps): bump uuid from 11.1.0 to 12.0.0 in /web

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 7.0.4 to 7.1.5. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v7.1.5/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 7.1.5 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

tests: adjust tests

JASPER 585: View court-list appearance details documents

….1.5 build(deps-dev): bump vite from 7.0.4 to 7.1.5 in /web

JASPER 582: Include case-number in document tab title

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 6.3.4 to 6.3.6. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v6.3.6/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v6.3.6/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 6.3.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* - Expose new CourtList endpoint handle viewing of document bundle - Create DocumentConverter to isolate the process for converting CfcDocument to CriminalDocuments - Update Binder mappings - Create Dtos to store request and response data for viewing document bundle - Add props for Binder and BinderDocument - Update BinderProcessBase to move JudicialBinder specific codes. - Create KeyDocumentBinderProcessor - CourtListService update where the core logic is. This includes binder initialization, generating pdf requests and merging. - Add keyDocsBinderRefreshHours to handle the state of key document binder * - Update ReportStrategy to use ReportServicesClient to avoid circular dependency - Add missing CourtClassCd label * - Make logic generic in preparation to handle Judicial Binders - Encode document id * cleanup * - Refactor InitializeBindersToMerge to address Cognitive Complexity - Address other SonarCloud issues. * Move KeyDocuments related code to its on function in an attemp to improve the functions cognitive complexity * - Add validation for KDProcessor - Fix other sonar cloud issues * Convert foreach to LINQ * Remove optional keys * - Exclude DocType=File where the filename is the same as the DocumentId. - Update courtClassCd to parse it in the BE instead * Add tests for DocumentConvert * - Fix failing unit test due to other change in the past - Ignore legacy unit tests to prevent the build to proceed when new/existing test fails. * Add unit test for KeyDocumentsBinderProcessor * Setting BinderDocDto DocumentId to null when mapping CriminalDocument that does not have an image id * - Handle scenarios where there are no binders and pdf request to merge - Add unit tests * Refactor document bundle process as per code review feedback * Remove refactored code from CourtList and skipped some tests so all unit tests passes for now. * Address sonar cloud issues * Use physicalFileId when querying criminal content * Add DocumentId null checking to exclude documents that does not have doc id * Cleanup and adding back unit tests --------- Co-authored-by: Ronaldo Macapobre <rmacapob@gov.bc.ca>

…le-view

refactor: make binder updateddate nullable

JASPER 578: View court-list key documents

Bumps [axios](https://github.com/axios/axios) from 1.8.2 to 1.12.0. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.8.2...v1.12.0) --- updated-dependencies: - dependency-name: axios dependency-version: 1.12.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [axios](https://github.com/axios/axios) from 1.11.0 to 1.12.0. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.11.0...v1.12.0) --- updated-dependencies: - dependency-name: axios dependency-version: 1.12.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…9.0.9 (#503) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authentication.OpenIdConnect dependency-version: 9.0.9 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Ronaldo Macapobre <rmacapob@gov.bc.ca>

…, All Documents (#510) - Fix issue when selecting Court Summary - Remove sorting of Judicial Binders Co-authored-by: Ronaldo Macapobre <rmacapob@gov.bc.ca>

- Use AWS_SECRET_PREFIX to access lz related secrets Co-authored-by: Ronaldo Macapobre <rmacapob@gov.bc.ca>

#504) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authentication.JwtBearer dependency-version: 9.0.9 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

--- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.NewtonsoftJson dependency-version: 9.0.9 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ew-new-tab

Always open new tab when viewing merged documents

Co-authored-by: Ronaldo Macapobre <rmacapob@gov.bc.ca>

api/Controllers/AuthController.cs


            //We are always sending X-Forwarded-Port, only time we aren't is when we are hitting the API directly. 
-            var baseUri = HttpContext.Request.Headers.ContainsKey("X-Forwarded-Host") ? $"{HttpContext.Request.Headers["X-Base-Href"]}logout" : "/api";
+            var baseUri = HttpContext.Request.Headers.ContainsKey("X-Forwarded-Host") ? $"{HttpContext.Request.Headers["X-Base-Href"]}" : "/api";


api/Controllers/AuthController.cs


            //We are always sending X-Forwarded-Port, only time we aren't is when we are hitting the API directly. 
-            var baseUri = HttpContext.Request.Headers.ContainsKey("X-Forwarded-Host") ? $"{HttpContext.Request.Headers["X-Base-Href"]}logout" : "/api";
+            var baseUri = HttpContext.Request.Headers.ContainsKey("X-Forwarded-Host") ? $"{HttpContext.Request.Headers["X-Base-Href"]}" : "/api";


api/Services/UserService.cs

        if (result == null || !result.Any())
        {
-            this.Logger.LogInformation("User with email: {email} is not found", email);
+            this.Logger.LogInformation("User with email: {Email} is not found", email.Replace(Environment.NewLine, ""));


To remediate, avoid logging the full, unsanitized email address. Replace it with a masked version that does not reveal the complete email, e.g. only log the email's domain or obscure part of the username. This minimizes the exposure of private information if logs are accessed inappropriately, while still providing operational context for debugging.
Specifically, edit api/Services/UserService.cs at line 77 so that the logged information is masked.
To implement masking, define a small method (either inline or at the class level, as allowed by shown code context) to safely obscure the email address. If the method can't be defined outside the method scope, create a simple inline masking in-place.
No additional imports are required.

sonarqubecloud · 2025-09-17T17:05:46Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

JTraill and others added 30 commits September 3, 2025 15:49

feat: nutrient updates

79b2554

Use JASPER's favicon (#480)

bb68c27

Co-authored-by: Ronaldo Macapobre <rmacapob@gov.bc.ca>

refactor: make the groupings more generic

f16b700

fix: add missing courtlist request mapping

tests: fix nutrient tests

53e093a

refactor: remove commented code

5656bf8

refactor: var to const

1f450b3

fix: wrong doc reference

4f5cdda

Merge pull request #483 from bcgov/nutrient-updates

0e7c3ba

JASPER 577: Nutrient updates

Merge pull request #457 from bcgov/jasper-121

c8468f2

jasper-121 add access request page with basic api to allow saving new…

correct request access screen's logo display.

0ba89a8

Bump GdPicture.API from 14.3.13 to 14.3.14

ed8db17

--- updated-dependencies: - dependency-name: GdPicture.API dependency-version: 14.3.14 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #486 from bcgov/dependabot/nuget/api/GdPicture.API…

d31026a

…-14.3.14 Bump GdPicture.API from 14.3.13 to 14.3.14

Merge pull request #489 from bcgov/dependabot/npm_and_yarn/web/uuid-1…

e3ee9b3

…2.0.0 build(deps): bump uuid from 11.1.0 to 12.0.0 in /web

feat: add viewability to court-list documents

88d0750

tests: adjust tests

Merge pull request #493 from bcgov/viewable-coourt-list-docs

362ceca

JASPER 585: View court-list appearance details documents

Merge pull request #487 from bcgov/dependabot/npm_and_yarn/web/vite-7…

6129199

….1.5 build(deps-dev): bump vite from 7.0.4 to 7.1.5 in /web

feat: rename document tab title on load

21276ff

refactor: function naming

0662912

Merge pull request #496 from bcgov/rename-file-tab

4391004

JASPER 582: Include case-number in document tab title

feat: port over bulde viewing changes

8a28a27

fix: wrongly mapped field

e9ab344

refactor: remove no longer used file

fb80d70

fix: rename fileid=>physicalfileid

c4d0f5c

JTraill and others added 21 commits September 15, 2025 16:54

test: rename fileid

06a77eb

test: rename fileid to physicalfileid

a719d38

fix: sonar issues

5ce1977

Merge branch 'master' of https://github.com/bcgov/jasper into fe-bund…

c250063

…le-view

refactor: types into own files and rename them

135c780

refactor: remove courtlist service from table

a2c393f

refactor: make binder updateddate nullable

refactor: remove inject from courtlisttable

3a37ef5

Merge pull request #509 from bcgov/fe-bundle-view

b218fe1

JASPER 578: View court-list key documents

update working directory for api gha (#511)

6bec8b2

Co-authored-by: Ronaldo Macapobre <rmacapob@gov.bc.ca>

- Default All Documents dropdown to Scheduled if available. Otherwise…

4d5eddd

…, All Documents (#510) - Fix issue when selecting Court Summary - Remove sorting of Judicial Binders Co-authored-by: Ronaldo Macapobre <rmacapob@gov.bc.ca>

refactor: force new tab each time file is viewed

dcb1e7b

- Add setting to delete pods after 3 days (#512)

b19f628

- Use AWS_SECRET_PREFIX to access lz related secrets Co-authored-by: Ronaldo Macapobre <rmacapob@gov.bc.ca>

Merge branch 'master' of https://github.com/bcgov/jasper into file-vi…

897d58f

…ew-new-tab

Merge pull request #513 from bcgov/file-view-new-tab

7e53906

Always open new tab when viewing merged documents

Update working directory to use . (#514)

12c68b2

Co-authored-by: Ronaldo Macapobre <rmacapob@gov.bc.ca>

github-advanced-security bot found potential problems Sep 17, 2025

View reviewed changes

ronaldo-macapobre temporarily deployed to test September 17, 2025 17:07 — with GitHub Actions Inactive

amlanc1 merged commit 48bbb26 into feature-jasper-lza-1 Sep 17, 2025
13 checks passed

ronaldo-macapobre temporarily deployed to prod September 17, 2025 17:15 — with GitHub Actions Inactive

ronaldo-macapobre temporarily deployed to prod September 17, 2025 17:16 — with GitHub Actions Inactive

@@ -38,6 +38,16 @@
                 private readonly IRepositoryBase<Role> _roleRepo = roleRepo;
                 private readonly IPermissionRepository _permissionRepo = permissionRepo;
+                // Masks email address for logging by obscuring the username part
+                private static string MaskEmail(string email)
+                {
+                    if (string.IsNullOrWhiteSpace(email)) return string.Empty;
+                    var parts = email.Split('@');
+                    if (parts.Length != 2) return "***";
+                    var username = parts[0].Length <= 2 ? "***" : parts[0].Substring(0, 2) + "***";
+                    return $"{username}@{parts[1]}";
+                }
                 public override string CacheName => "GetUsersAsync";
                 public override async Task<OperationResult<UserDto>> ValidateAsync(UserDto dto, bool isEdit = false)
@@ -74,7 +84,7 @@
                     var result = await this.Repo.FindAsync(u => u.Email == email);
                     if (result == null || !result.Any())
                     {
-                        this.Logger.LogInformation("User with email: {Email} is not found", email.Replace(Environment.NewLine, ""));
+                        this.Logger.LogInformation("User with email: {Email} is not found", MaskEmail(email));
                         return null;
                     }

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates from master#515

Updates from master#515
amlanc1 merged 51 commits intofeature-jasper-lza-1from
master

amlanc1 commented Sep 17, 2025

Uh oh!

Check warning

Check warning

Check warning

Copilot Autofix

sonarqubecloud bot commented Sep 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

amlanc1 commented Sep 17, 2025

Pull Request for JIRA Ticket: ----put ticket number here----

Issue ticket number and link

Description

Type of change

How Has This Been Tested?

Checklist:

Documentation References

Uh oh!

Check warning

Check warning

Check warning

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot Autofix

sonarqubecloud bot commented Sep 17, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants