Resolved static code analysis issues found by tfsec

[ronaldo-macapobre]

Pull Request for JIRA Ticket: JASPER-93

Issue ticket number and link

https://jag.gov.bc.ca/jira/browse/JASPER-93

Description

• Changes are based from tfsec's recommendation to resolve static code analysis errors.

• @amlanc1 and I agreed to commented out the test s3 related changes for the meantime to avoid tfsec to scan it. It will be retained for future reference.

• There are still 5 critical errors that remains in tfsec which I think will be resolved once the Network Architecture has been finalized

  1. Listener for application load balancer does not use HTTPS.
  2. Security group rule allows ingress from public internet.
  3. CRITICAL Security group rule allows ingress from public internet.
  4. CRITICAL Security group rule allows egress to multiple public internet addresses.
  5. CRITICAL Security group rule allows egress to multiple public internet addresses.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Trigger the Build and Deploy Infra workflows targeting feature branch.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings

[WadeBarnes]

One recommendation.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[amlanc1]

lgtm