jasper-121 add access request page with basic api to allow saving new… by devinleighsmith · Pull Request #457 · bcgov/jasper

devinleighsmith · 2025-08-27T20:59:18Z

… user access request.

Pull Request for JIRA Ticket: ----121----

Issue ticket number and link

Include the JIRA ticket # and link here
https://jira.justice.gov.bc.ca/browse/JASPER-121

Description

Partial implementation of 121, handles case where user is new, has no roles, and does not exist in PCSS.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test using idir login with no user in mongoDB. Validate that the user is redirected to access request screen and that user is able to submit request.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

Documentation References

Put any doc references here

devinleighsmith · 2025-08-27T20:59:52Z

Let me know if there is anything I missed - first pull request, tried to follow the checklist and what I've seen from PRs I've reviewed.

devinleighsmith · 2025-08-27T21:00:07Z

will deal with conflict.

api/Controllers/UsersController.cs

JTraill · 2025-08-27T21:02:46Z

web/src/components/dashboard/RequestAccess.vue

We're in the process of deprecating vue-bootstrap-next in favor of Vuetify. All new FE components should use Vuetify

JTraill · 2025-08-27T21:03:13Z

web/src/components/dashboard/RequestAccess.vue

+  </b-card>
+</template>
+
+<script lang="ts">


Recommend converting this to a script setup

api/Services/UserService.cs

devinleighsmith · 2025-08-28T00:38:09Z

I'm putting this in draft as I'm no longer seeing claims for first name, last name, or a guid coming back from keycloak.

ronaldo-macapobre · 2025-08-28T01:15:28Z

api/Controllers/UsersController.cs

+    [Route("request-access")]
+    public async Task<ActionResult> RequestAccess(string email)
+    {
+        var userIdentifier = User.Claims.FirstOrDefault(c => c.Type == "preferred_username")?.Value;


You will be able to utilize the extension methods in ClaimsPrincipalExtensions.cs. e.g. User.PreferredUsername()

ronaldo-macapobre · 2025-08-28T01:17:19Z

api/Controllers/UsersController.cs

+        Guid.TryParse(userIdentifier?.Split("@").FirstOrDefault(), out userGuid);
+        var newUser = new UserDto()
+        {
+            FirstName = User.Claims.FirstOrDefault(c => c.Type == "given_name")?.Value,


Might better to use the code below to avoid hard coded strings.

Suggested change

FirstName = User.Claims.FirstOrDefault(c => c.Type == "given_name")?.Value,

FirstName = User.FindFirstValue(ClaimTypes.GivenName),

LastName = User.FindFirstValue(ClaimTypes.Surname),

ronaldo-macapobre · 2025-08-28T01:18:22Z

api/Controllers/UsersController.cs

+            ADId = userGuid,
+            ADUsername = userIdentifier,
+        };
+        var result = await base.Create(newUser); // Note: this handles validation and duplicate prevention.


Might be better to change the route to HttpPost because it creates a user?

devinleighsmith · 2025-09-02T19:59:45Z

api/Controllers/AuthController.cs

                UserId = HttpContext.User.UserId(),
                JudgeId = HttpContext.User.JudgeId(),
+                Email = HttpContext.User.Email(),
+                IsActive = HttpContext.User.IsActive(),


@ronaldo-macapobre I added the active flag here for now, but the issue I was having in testing with the current implementation is that changes to a user in the database are not reflected in these UserContext properties without a user being logged out or starting a new incognito session - we may want to rethink this flow if we want to, for example, disable a user and have their access revoked immediately.

@devinleighsmith I see, we can force the user to logout or invalidate his session upon updating the access. That way the user is forced to relogin.

@ronaldo-macapobre perhaps a check in the permissionhandler, if the active flag or the groupIds have changed? That logic needs to be in one of the handlers in my OP to catch when a change has been made in the db that isn't reflected in the current user's cached claims.

Moving PR to draft to add this.

devinleighsmith · 2025-09-02T20:01:53Z

api/Infrastructure/Authorization/ProviderAuthorizationHandler.cs

+                return Task.CompletedTask;
+            }
+
+            if (!user.IsActive())


@ronaldo-macapobre I added this here to correspond with my changes - however, in current state the session has to expire for updates to this property to change here - we may want to get the user from the db here instead.

… user access request. updates from SONAR recommendations. codeql, sonarqube updates. Includes Josh's requested changes. snapshot updates. remove debugging console logs. sanitize logged user email (codeQL). add snapshot serializer to avoid data-v component unique ids failing snapshot tests. correct pascal case warning. force snapshot render to wait for component to be finished rendering. wrap snapshot in wait in case difference caused by async logic. correct snapshot by running all tests not using test runner. updates based on Ronnie's changes. perform an update on an existing user, as we can assume the userId will already be in place. check for user based on userid instead of email. updates based on ronaldo's changes, updates existing user. snapshot correction. Correct potential null-pointer if user not found. jasper-121 final updates based on testing - ensure that active/inactive users are not redirected appropriately.

…udicial styling. correct build issue. add jasper png

s

ronaldo-macapobre · 2025-09-03T15:17:52Z

db/Models/User.cs


        public bool IsActive { get; set; }

+        public bool? IsPendingRegistration { get; set; } = false;


Do we really need this to be nullable because the same field in UserDto is not nullable.

ronaldo-macapobre · 2025-09-03T15:24:30Z

web/src/types/common/index.ts

+  roles: string[];
  subRole: string;
  isSupremeUser: string;
+  isPendingRegistration?: boolean;


Kindly update if this is no longer nullable.

ronaldo-macapobre · 2025-09-03T15:26:25Z

web/src/utils/utils.ts

+  return _.isNumber(value) && value > 0;
+};
+
+export class CustomAPIError<T> extends Error {


I wonder if this should be placed in the ApiResponse.ts instead?

… on. Check user for changes during authorization handler.

devinleighsmith · 2025-09-04T16:36:48Z

api/Controllers/AuthController.cs

            var forwardedPort = HttpContext.Request.Headers["X-Forwarded-Port"];

            //We are always sending X-Forwarded-Port, only time we aren't is when we are hitting the API directly. 
-            var baseUri = HttpContext.Request.Headers.ContainsKey("X-Forwarded-Host") ? $"{HttpContext.Request.Headers["X-Base-Href"]}logout" : "/api";


This appears to have been copy/pasted from sheriff-scheduling, but doesn't work for us at the moment since we don't have a /logout page on the frontend.

Yup. This came along when we forked the Supreme Court Viewer repo.

devinleighsmith · 2025-09-04T16:37:07Z

api/Controllers/UsersController.cs

    /// Allows a new user without authorization to JASPER to request access to the application.
    /// </summary>
    /// <returns>The user resulting from the access request.</returns>
-    [Authorize(AuthenticationSchemes = "SiteMinder, OpenIdConnect", Policy = nameof(ProviderAuthorizationHandler))]


this is already present at the controller level.

devinleighsmith · 2025-09-04T16:38:47Z

api/Infrastructure/Authorization/AuthorizationServiceCollectionExtension.cs

    {
        public static IServiceCollection AddScvAuthorization(this IServiceCollection services)
        {
+            services.AddScoped<IUserService, UserService>();


these need to be scoped, or race conditions may cause multiple, simultaneous requests to the user repository methods.

devinleighsmith · 2025-09-04T16:42:03Z

api/Infrastructure/Authorization/ProviderAuthorizationHandler.cs

+                var databaseUser = await _userService.GetByIdWithPermissionsAsync(userId);
+                if (databaseUser == null || context.User.HasChanged(databaseUser))
+                {
+                    context.Fail(new AuthorizationFailureReason(this, "User claims changed since last authentication."));


AuthorizationHandlers are not supposed to handle redirects directly - so flag the authorizationRedirectMiddleware with a unique failure reason.

api/Services/UserService.cs

        if (result == null || !result.Any())
        {
-            this.Logger.LogInformation("User with email: {email} is not found", email);
+            this.Logger.LogInformation("User with email: {Email} is not found", email.Replace(Environment.NewLine, ""));


ronaldo-macapobre · 2025-09-04T17:49:39Z

api/Helpers/Extensions/ClaimsPrincipalExtensions.cs

@@ -1,4 +1,6 @@
-using System;
+using DocumentFormat.OpenXml.InkML;


do we really need this namespace?

sonarqubecloud · 2025-09-04T18:29:49Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

devinleighsmith self-assigned this Aug 27, 2025

devinleighsmith added the enhancement New feature or request label Aug 27, 2025

github-advanced-security bot found potential problems Aug 27, 2025

View reviewed changes

api/Controllers/UsersController.cs Fixed Show fixed Hide fixed

api/Controllers/UsersController.cs Fixed Show fixed Hide fixed

JTraill reviewed Aug 27, 2025

View reviewed changes

devinleighsmith force-pushed the jasper-121 branch from 1cc9a9d to 7a73312 Compare August 27, 2025 21:05

github-advanced-security bot found potential problems Aug 27, 2025

View reviewed changes

api/Services/UserService.cs Fixed Show fixed Hide fixed

devinleighsmith marked this pull request as draft August 28, 2025 00:37

ronaldo-macapobre reviewed Aug 28, 2025

View reviewed changes

WadeBarnes mentioned this pull request Aug 28, 2025

JASPER-551: Implement a mapping field in JASPER that can be used to derive the PCSS user details (PART 2) #458

Merged

9 tasks

devinleighsmith force-pushed the jasper-121 branch from c8ed2cf to 3c214a8 Compare August 30, 2025 00:13

devinleighsmith commented Sep 2, 2025

View reviewed changes

devinleighsmith marked this pull request as ready for review September 2, 2025 22:57

devinleighsmith added 2 commits September 2, 2025 16:41

as per Wade, change styling of access request to be consistent with j…

2e8d334

…udicial styling. correct build issue. add jasper png

devinleighsmith force-pushed the jasper-121 branch from 60a3813 to ff003f5 Compare September 2, 2025 23:42

cleanup, remove unecessary console.log, use jasper svg.

63a0a95

s

devinleighsmith force-pushed the jasper-121 branch from ff003f5 to 63a0a95 Compare September 2, 2025 23:45

move active user check to permission handler.

63ff39e

ronaldo-macapobre reviewed Sep 3, 2025

View reviewed changes

devinleighsmith marked this pull request as draft September 3, 2025 16:44

PR comments.

a3998b4

log user out if they have been meaningfully updated since they logged…

c91ecb9

… on. Check user for changes during authorization handler.

devinleighsmith marked this pull request as ready for review September 4, 2025 16:32

minor pascal case correction to loggers.

d83ab40

devinleighsmith commented Sep 4, 2025

View reviewed changes

re-add missing authorization handler

698a6b8

devinleighsmith commented Sep 4, 2025

View reviewed changes

github-advanced-security bot found potential problems Sep 4, 2025

View reviewed changes

ronaldo-macapobre reviewed Sep 4, 2025

View reviewed changes

ronaldo-macapobre approved these changes Sep 4, 2025

View reviewed changes

devinleighsmith added 2 commits September 4, 2025 11:06

remove unused import.

2a25395

remove duplicate IUser declaration.

f335f1a

WadeBarnes approved these changes Sep 4, 2025

View reviewed changes

devinleighsmith merged commit c8468f2 into master Sep 5, 2025
9 checks passed

	FirstName = User.Claims.FirstOrDefault(c => c.Type == "given_name")?.Value,
	FirstName = User.FindFirstValue(ClaimTypes.GivenName),
	LastName = User.FindFirstValue(ClaimTypes.Surname),


		public bool IsActive { get; set; }

		public bool? IsPendingRegistration { get; set; } = false;

		@@ -1,4 +1,6 @@
		using System;
		using DocumentFormat.OpenXml.InkML;

Conversation

devinleighsmith commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request for JIRA Ticket: ----121----

Issue ticket number and link

Description

Type of change

How Has This Been Tested?

Checklist:

Documentation References

Uh oh!

devinleighsmith commented Aug 27, 2025

Uh oh!

devinleighsmith commented Aug 27, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devinleighsmith commented Aug 28, 2025

Uh oh!

ronaldo-macapobre Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ronaldo-macapobre Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Check warning

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ronaldo-macapobre Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Sep 4, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

devinleighsmith commented Aug 27, 2025 •

edited

Loading

ronaldo-macapobre Aug 28, 2025 •

edited

Loading

ronaldo-macapobre Sep 4, 2025 •

edited

Loading

ronaldo-macapobre Sep 4, 2025 •

edited

Loading