Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add readme to perception related utils #4265

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Conversation

miursh
Copy link
Contributor

@miursh miursh commented Jul 13, 2023

Description

Add README to the following packages

  • perception_utils
  • object_recognition_utils
  • traffic_light_utils
  • cuda_utils
  • tensorrt_common
  • trtexec_vendor

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Jul 13, 2023
@miursh miursh marked this pull request as draft July 13, 2023 00:52
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@miursh miursh marked this pull request as ready for review July 13, 2023 01:06
Copy link
Contributor

@yukke42 yukke42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@manato manato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I appreciate your prompt dealing with this case.

Copy link
Contributor

@scepter914 scepter914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (4d9d98f) 14.20% compared to head (186e123) 14.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4265      +/-   ##
==========================================
- Coverage   14.20%   14.20%   -0.01%     
==========================================
  Files        1597     1597              
  Lines      109902   109903       +1     
  Branches    31526    31526              
==========================================
  Hits        15613    15613              
- Misses      77338    77339       +1     
  Partials    16951    16951              
Flag Coverage Δ *Carryforward flag
differential 9.60% <ø> (?)
total 14.20% <ø> (ø) Carriedforward from 4d9d98f

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@miursh miursh merged commit 4b12f01 into main Jul 13, 2023
@miursh miursh deleted the docs/add_readme_to_utils branch July 13, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants