Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(behavior_velocity_planner): new framework for creating virtual wall markers(#3851) #3870

Closed
wants to merge 262 commits into from
Closed

refactor(behavior_velocity_planner): new framework for creating virtual wall markers(#3851) #3870

wants to merge 262 commits into from

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented May 30, 2023 •
edited
Loading

Description

Hotfix to beta/v0.8.0
#3851 PR by @maxime-clem

Tests performed

confirmed scenario_simulator's result including CI ondemand view.

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

awf-autoware-bot bot and others added 30 commits April 6, 2022 14:32
@awf-autoware-bot @kenji-miyake
@pre-commit-ci @h-ohta
chore: sync files (#629)
4a3e529 
* chore: sync files

Signed-off-by: GitHub <noreply@github.com>

* ci(pre-commit): autofix

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@awf-autoware-bot @kenji-miyake @h-ohta
chore: sync files (#637)
3dea07d 
Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
@h-ohta
fix(dummy_diag_publisher): use anon to make unique node name instead …
f037c18 
…of diag name (#639)
@tier4-autoware-public-bot
Merge pull request #32 from tier4/sync-upstream
0c2022a 
chore: sync upstream
@yn-mrse
Merge branch 'tier4/main' into sync-upstream
a4e7e2f
@tier4-autoware-public-bot
Merge pull request #33 from tier4/sync-upstream
b9fb070 
chore: sync upstream
@tier4-autoware-public-bot
Merge pull request #35 from tier4/sync-upstream
840d3e9 
fix(obstacle_stop_planner): use utils function to caluculate nearest index from ego (#651)
@awf-autoware-bot @kenji-miyake @h-ohta
chore: sync files (#648)
3a37242 
* chore: sync files

Signed-off-by: GitHub <noreply@github.com>

* Revert "chore: sync files"

This reverts commit b24f530.

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* sync codecov.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
@h-ohta @pre-commit-ci
fix(autoware_state_panel): fix message type for /api/autoware/get/eng…
a827200 
…age (#666)

* fix(autoware_state_panel): fix message type for /api/autoware/get/engage

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@tier4-autoware-public-bot
Merge pull request #36 from tier4/sync-upstream
cc39553 
chore: sync upstream
@tier4-autoware-public-bot
Merge pull request #37 from tier4/sync-upstream
75b9e2d 
chore: sync upstream
@tier4-autoware-public-bot
Merge pull request #39 from tier4/sync-upstream
8278cce 
chore: sync upstream
@tier4-autoware-public-bot
Merge pull request #41 from tier4/sync-upstream
e0ad67a 
chore: sync upstream
@tier4-autoware-public-bot
Merge pull request #42 from tier4/sync-upstream
6174d32 
chore: sync upstream
@tier4-autoware-public-bot
Merge pull request #43 from tier4/sync-upstream
65e6d7b 
chore: sync upstream
@taikitanaka3 @0x126
fix(behavior_velocity): avoid insert same point on trajectory utils (#…
9f5837f 
…834)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@kenji-miyake @0x126
refactor(behavior_velocity_planner): simplify CMakeLists.txt (#855)
69fc674 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@Sharrrrk @pre-commit-ci
@wep21 @0x126
fix(system_monitor): fix build error on tegra platform (#869)
063a95d 
* fix(system_monitor): fix build error on tegra platform

Signed-off-by: Shark Liu <shark.liu@autocore.ai>

* ci(pre-commit): autofix

* Update system/system_monitor/src/gpu_monitor/tegra_gpu_monitor.cpp

Co-authored-by: Shark Liu <shark.liu@autocore.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
@takayuki5168 @kenji-miyake @0x126
feat(ad_service_state_monitor): limit odometry buffer size (#514)
35a1f0a 
* feat(ad_service_state_monitor): limit odometry buffer size 40

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Update system/ad_service_state_monitor/src/ad_service_state_monitor_node/ad_service_state_monitor_node.cpp

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Update ad_service_state_monitor_node.cpp

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
@Shin-kyoto @0x126
docs: fix 404 error caused by typo in url (#871)
82c6ad8 
* docs: fix 404 error caused by typo in url

Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>

* docs: fix typo in url for yolov4

Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
@storrrrrrrrm @pre-commit-ci @0x126
fix(image_projection_based_fusion): set imagebuffersize (#820)
a7118b6 
* fix: set imagebuffersize configured

Signed-off-by: suchang <chang.su@autocore.ai>

* ci(pre-commit): autofix

Co-authored-by: suchang <chang.su@autocore.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@zulfaqar-azmi-t4 @0x126
chore(avoidance_module): fix spell check (#732)
8809673 
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@maxime-clem @0x126
feat: isolate gtests in all packages (#693)
cc43203 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@taikitanaka3 @kenji-miyake @0x126
docs(virtual traffic light): add documentation (#245)
0786fa1 
* doc(behavior_velocity): add graph and fix link

* doc(behavior_velocity): update virtual traffic light doc

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* doc(behavior_velocity): minor fix

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* doc : mediate to coordinate

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* doc: minor update

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* doc: fix pre-commit

* doc: update docs

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* apply suggestion

* doc: to intersection-coordination

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
@satoshi-ota @0x126
feat(surround_obstacle_checker): separate surround_obstacle_checker f…
4f4644f 
…rom hierarchical planning flow (#830)

* fix(surroud_obstacle_checker): use alias

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(surround_obstacle_checker): use velocity limit

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(surround_obstacle_checker): rename publisher, subscriber and callback functions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(surround_obstacle_checker): use parameter struct

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(surround_obstacle_checker): use alias

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(surround_obstacle_checker): cleanup member functions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(surround_obstacle_checker): cleanup polygon handling

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(surround_obstacle_checker): use marker helper

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(planning_launch): separate surround_obstacle_checker from hierarchical motion planning flow

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@yukkysaito @0x126
feat: remove deprecated package in prediction launch (#875)
1f5ade6 
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
@satoshi-ota @0x126
fix(surround_obstacle_checker): fix ego footprint polygon (#877)
399c133 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@wep21 @0x126
fix: update nvinfer api (#863)
eca2944 
* fix(lidar_centerpoint): update nvinfer api

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* fix(tensorrt_yolo): update nvinfer api

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* fix(lidar_apollo_instance_segmentation): update nvinfer api

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* fix(traffic_light_classifier): update nvinfer api

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* fix(traffic_light_ssd_fine_detector): update nvinfer api

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* pre-commit run

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
@zulfaqar-azmi-t4 @0x126
fix(avoidance_module): ignore object instead of creating zero shift (#…
3e5e6db 
…731)

* fix: ignore object instead of creating zero shift

instead of creating zero shift point, the object will be ignored.
no behavior changes should be observed.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* refactor: sync continue with upstream

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix: fix debug message for insufficient lateral margin

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@TakaHoribe @0x126
fix(motion_velocity_smoother): curve deceleration not working with a …
7b81507 
…specific parameter set (#738)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@codecov
Copy link

codecov bot commented May 30, 2023 •
edited
Loading

Codecov Report

Patch coverage: 19.90% and project coverage change: +0.03 🎉

Comparison is base (6dc8617) 14.11% compared to head (151ed11) 14.15%.

❗ Current head 151ed11 differs from pull request most recent head 307e373. Consider uploading reports for the commit 307e373 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           v0.8.0    #3870      +/-   ##
==========================================
+ Coverage   14.11%   14.15%   +0.03%     
==========================================
  Files        1438     1441       +3     
  Lines      101442   101501      +59     
  Branches    27021    27081      +60     
==========================================
+ Hits        14320    14366      +46     
+ Misses      71442    71395      -47     
- Partials    15680    15740      +60
Flag Coverage Δ *Carryforward flag
differential 18.16% <19.90%> (?)
total 14.13% <ø> (+0.02%) ⬆️ Carriedforward from 6dc8617

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
common/motion_utils/src/marker/marker_helper.cpp 55.00% <ø> (+27.41%) ⬆️
.../behavior_velocity_blind_spot_module/src/debug.cpp 0.00% <0.00%> (ø)
.../behavior_velocity_blind_spot_module/src/scene.hpp 0.00% <ø> (ø)
...g/behavior_velocity_crosswalk_module/src/debug.cpp 0.00% <0.00%> (ø)
...avior_velocity_detection_area_module/src/debug.cpp 0.00% <0.00%> (ø)
...ehavior_velocity_intersection_module/src/debug.cpp 0.00% <0.00%> (ø)
...ity_intersection_module/src/scene_intersection.hpp 0.00% <ø> (ø)
...ior_velocity_no_stopping_area_module/src/debug.cpp 0.00% <0.00%> (ø)
...avior_velocity_occlusion_spot_module/src/debug.cpp 0.00% <0.00%> (ø)
...ocity_out_of_lane_module/src/scene_out_of_lane.cpp 0.00% <0.00%> (ø)
... and 12 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxime-clem @kyoichi-sugahara
refactor(behavior_velocity_planner): new framework for creating virtu…
307e373 
…al wall markers (autowarefoundation#3851)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara kyoichi-sugahara force-pushed the hotfix/VirtualWallMarkerCreator branch from 151ed11 to 307e373 Compare May 31, 2023 03:33
@github-actions github-actions bot added type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) labels May 31, 2023
@kyoichi-sugahara
Copy link
Contributor Author

Sorry I made PR by mistake

@tkimura4 tkimura4 deleted the hotfix/VirtualWallMarkerCreator branch May 31, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@purewater0901 purewater0901 Awaiting requested review from purewater0901

@amc-nu amc-nu Awaiting requested review from amc-nu amc-nu is a code owner

@miursh miursh Awaiting requested review from miursh miursh is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

@maxime-clem maxime-clem Awaiting requested review from maxime-clem maxime-clem is a code owner

@brkay54 brkay54 Awaiting requested review from brkay54

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@mkuri mkuri Awaiting requested review from mkuri mkuri is a code owner

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

@YoshiRi YoshiRi Awaiting requested review from YoshiRi YoshiRi is a code owner

@yukke42 yukke42 Awaiting requested review from yukke42

@badai-nguyen badai-nguyen Awaiting requested review from badai-nguyen badai-nguyen is a code owner

@kminoda kminoda Awaiting requested review from kminoda kminoda is a code owner

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r mitsudome-r is a code owner

@RyuYamamoto RyuYamamoto Awaiting requested review from RyuYamamoto RyuYamamoto is a code owner

@kenji-miyake kenji-miyake Awaiting requested review from kenji-miyake

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.