-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(behavior_velocity_planner): new framework for creating virtual wall markers #3851
refactor(behavior_velocity_planner): new framework for creating virtual wall markers #3851
Conversation
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
c0d93ce
to
39c9409
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3851 +/- ##
==========================================
- Coverage 15.09% 14.14% -0.95%
==========================================
Files 1332 1441 +109
Lines 94938 101617 +6679
Branches 27063 27123 +60
==========================================
+ Hits 14330 14376 +46
- Misses 64920 71493 +6573
- Partials 15688 15748 +60
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@maxime-clem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really appreciate for you PR ! And adding gtests is really nice !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!! Thank you!
…al wall markers (autowarefoundation#3851) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…al wall markers (autowarefoundation#3851) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…al wall markers (autowarefoundation#3851) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…al wall markers (autowarefoundation#3851) (#548) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
Description
Implement a new framework for managing virtual wall markers in the
behavior_velocity_planner
.This simplifies the creation of the markers, moving the responsibility of (1) assigning unique IDs and (2) creating
DELETE
markers from scene modules to scene managers.VirtualWallMarkerCreator
classVirtualWall
objects and each manager creates the markers using theVirtualWallMarkerCreator
classTests performed
Test by visualizing virtual walls in the simple planning simulator.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.