Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity_planner): new framework for creating virtual wall markers #3851

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented May 29, 2023

Description

Implement a new framework for managing virtual wall markers in the behavior_velocity_planner.
This simplifies the creation of the markers, moving the responsibility of (1) assigning unique IDs and (2) creating DELETE markers from scene modules to scene managers.

Before After
Each scene directly creates markers using the VirtualWallMarkerCreator class Each scene creates VirtualWall objects and each manager creates the markers using the VirtualWallMarkerCreator class
image image

Tests performed

Test by visualizing virtual walls in the simple planning simulator.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels May 29, 2023
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem force-pushed the refactor/VirtualWallMarkerCreator branch from c0d93ce to 39c9409 Compare May 29, 2023 04:20
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage: 19.90% and project coverage change: -0.95 ⚠️

Comparison is base (527aaf7) 15.09% compared to head (39c9409) 14.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3851      +/-   ##
==========================================
- Coverage   15.09%   14.14%   -0.95%     
==========================================
  Files        1332     1441     +109     
  Lines       94938   101617    +6679     
  Branches    27063    27123      +60     
==========================================
+ Hits        14330    14376      +46     
- Misses      64920    71493    +6573     
- Partials    15688    15748      +60     
Flag Coverage Δ *Carryforward flag
differential 18.15% <19.90%> (?)
total 14.13% <ø> (-0.97%) ⬇️ Carriedforward from 164fcd6

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
common/motion_utils/src/marker/marker_helper.cpp 55.00% <ø> (+27.41%) ⬆️
.../behavior_velocity_blind_spot_module/src/debug.cpp 0.00% <0.00%> (ø)
.../behavior_velocity_blind_spot_module/src/scene.hpp 0.00% <ø> (ø)
...g/behavior_velocity_crosswalk_module/src/debug.cpp 0.00% <0.00%> (ø)
...avior_velocity_detection_area_module/src/debug.cpp 0.00% <0.00%> (ø)
...ehavior_velocity_intersection_module/src/debug.cpp 0.00% <0.00%> (ø)
...ity_intersection_module/src/scene_intersection.hpp 0.00% <ø> (ø)
...ior_velocity_no_stopping_area_module/src/debug.cpp 0.00% <0.00%> (ø)
...avior_velocity_occlusion_spot_module/src/debug.cpp 0.00% <0.00%> (ø)
...ocity_out_of_lane_module/src/scene_out_of_lane.cpp 0.00% <0.00%> (ø)
... and 12 more

... and 107 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxime-clem maxime-clem marked this pull request as ready for review May 29, 2023 06:46
@kyoichi-sugahara
Copy link
Contributor

@maxime-clem
Thank you so much!!
I will check the behavior.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@soblin soblin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate for you PR ! And adding gtests is really nice !

@maxime-clem maxime-clem enabled auto-merge (squash) May 30, 2023 02:05
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! Thank you!

@maxime-clem maxime-clem merged commit 1e8b9d5 into autowarefoundation:main May 30, 2023
@maxime-clem maxime-clem deleted the refactor/VirtualWallMarkerCreator branch May 30, 2023 10:07
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request May 30, 2023
…al wall markers (autowarefoundation#3851)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request May 30, 2023
…al wall markers (autowarefoundation#3851)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request May 31, 2023
…al wall markers (autowarefoundation#3851)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request May 31, 2023
…al wall markers (autowarefoundation#3851) (#548)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants