feat(crossseed): add custom category option for cross-seeds

[s0up4200]

Summary

• Adds a third category mode for cross-seeds: custom category
• Three mutually exclusive modes now available via RadioGroup UI:
  • Suffix mode (default): appends .cross to matched torrent's category
  • Indexer mode: uses indexer name as category
  • Custom mode: uses exact user-specified category name
• Custom category mode disables autoTMM (like indexer mode) for safety
• Frontend includes creatable dropdown with suggestions from existing qBittorrent categories

Test plan

• Verify RadioGroup displays all three category modes
• Verify selecting custom mode shows the category input dropdown
• Verify custom category persists after save/reload
• Verify cross-seeds use exact custom category without any suffix
• Verify autoTMM is disabled for custom category mode
• Verify switching between modes updates settings correctly

Summary by CodeRabbit

• New Features

  • Added a single category-mode selector (suffix, indexer, custom) with updated UI controls and radio-group input.
  • Added custom category option allowing a static category name (no suffix) and creation of custom categories in the UI.
  • Settings now persist and surface the selected category mode.

• Documentation

  • Updated cross-seeding docs to explain the three modes, their save-path behavior, and mode-dependent AutoTMM rules.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Adds a configurable cross-seed category mode (suffix | indexer | custom), persists new settings in the DB, threads custom-category through models and services (affecting autoTMM logic and decision paths), and updates frontend UI/types with a RadioGroup and custom-category input.

Changes

Cohort / File(s)	Change Summary
Documentation README.md, docs/CROSS_SEEDING.md	Replace prior comparison with a three-mode category system (suffix, indexer, custom); clarify per-mode autoTMM behavior, save-path resolution, piece-boundary safety, and related notes.
DB Migration internal/database/migrations/046_add_cross_seed_custom_category.sql	Add use_custom_category (BOOLEAN NOT NULL DEFAULT false) and custom_category (TEXT DEFAULT '') to cross_seed_settings.
Backend Models internal/models/crossseed.go	Add UseCustomCategory (bool) and CustomCategory (string) to CrossSeedAutomationSettings; read/write/default handling added.
Backend Services & Tests internal/services/crossseed/service.go, internal/services/crossseed/auto_tmm_test.go	Thread useCustomCategory through category resolution and shouldEnableAutoTMM (signature and callers updated); prioritize custom category when set; update tests and decision logging.
Frontend Types web/src/types/index.ts	Add useCustomCategory and customCategory to CrossSeedAutomationSettings and optional fields to the patch type.
Frontend UI & Components web/src/pages/CrossSeedPage.tsx, web/src/components/ui/radio-group.tsx	Introduce CategoryMode (`"suffix"
Web Dependencies web/package.json	Add @radix-ui/react-radio-group (^1.3.8).

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Browser as Client (UI)
  participant API as Server (HTTP/API)
  participant DB as Database
  participant Svc as CrossSeed Service

  Note over Browser,API: User selects category mode and optional customCategory
  User->>Browser: choose mode + (optional) customCategory
  Browser->>API: PATCH /settings { useCustomCategory, customCategory, useCategoryFromIndexer, ... }
  API->>DB: UPSERT cross_seed_settings (use_custom_category, custom_category, ...)
  DB-->>API: ACK
  API-->>Browser: 200 OK

  Note over Svc,DB: Later, on cross-seed match
  Svc->>DB: SELECT cross_seed_settings for account
  DB-->>Svc: (use_custom_category, custom_category, use_category_from_indexer, ...)
  Svc->>Svc: determineCrossSeedCategory(mode, custom_category, matchedCategory, indexerName)
  Svc->>Svc: shouldEnableAutoTMM(crossCategory, matchedAutoManaged, useCategoryFromIndexer, useCustomCategory, matchedSavePath)
  alt autoTMM enabled
    Svc->>Svc: proceed with auto-managed save logic
  else autoTMM disabled
    Svc->>Svc: require explicit save path / manual handling
  end

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

• fix(crossseed): inherit TMM state from matched torrent #654 — Modifies cross-seed autoTMM decision logic; overlaps with shouldEnableAutoTMM changes and test updates.
• feat(cross-seed) cross category suffixing #669 — Changes cross-seed category handling and DB-backed flags; overlaps with category-mode and migration work.
• fix(crossseed): resolve category creation race condition and relax autoTMM #767 — Alters shouldEnableAutoTMM call sites and tests; related to autoTMM decision-path updates.

Suggested labels

enhancement, cross-seed, web

Poem

🐇 I hopped through code and database, too,

Three modes to pick — suffix, indexer, or new.
A radio click, a custom name tucked in,
DB writes done — let cross-seeds begin! 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title accurately and concisely describes the main feature: adding a custom category option for cross-seeds, which aligns with the substantial changes across backend models, database migrations, and frontend UI components.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/cross-seed-custom-category

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

web/src/pages/CrossSeedPage.tsx (1)

2483-2491: Consider using a single-select component for custom category.

The MultiSelect component is repurposed for single-value selection by taking values[0]. While this works correctly, a dedicated single-select creatable dropdown component would be more semantically appropriate and might provide better UX.

That said, the current implementation functions correctly and the creatable feature works as intended. This is more of a future enhancement suggestion.

internal/services/crossseed/service.go (1)

2961-3036: Custom-category flag correctly integrated into autoTMM decision

The extra useCustomCategory flag is plumbed from GetAutomationSettings into shouldEnableAutoTMM and the decision logging, so custom mode cleanly participates in the same decision flow as indexer mode. This matches the “custom mode disables autoTMM” requirement and doesn’t add any new calls to GetAutomationSettings beyond what was already there.

If you ever want to reduce settings lookups, a future (optional) refactor could pass a single *CrossSeedAutomationSettings down into both determineCrossSeedCategory and this TMM decision instead of reloading inside each helper, but that’s not urgent given this is a single-row settings table.

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3172ad9 and ee5c4f4.

⛔ Files ignored due to path filters (1)

• web/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (10)

• README.md
• docs/CROSS_SEEDING.md
• internal/database/migrations/046_add_cross_seed_custom_category.sql
• internal/models/crossseed.go
• internal/services/crossseed/auto_tmm_test.go
• internal/services/crossseed/service.go
• web/package.json
• web/src/components/ui/radio-group.tsx
• web/src/pages/CrossSeedPage.tsx
• web/src/types/index.ts

🧰 Additional context used

🧠 Learnings (6)

📚 Learning: 2025-12-19T07:24:42.043Z

Learnt from: s0up4200
Repo: autobrr/qui PR: 825
File: internal/models/crossseed.go:68-68
Timestamp: 2025-12-19T07:24:42.043Z
Learning: In the autobrr/qui repository, SQLite migrations should use DEFAULT 0 for boolean column defaults instead of DEFAULT FALSE. This ensures consistency with SQLite typing and avoids potential confusion, even though both are functionally equivalent for SQLite. Apply this rule to all SQL migration files (e.g., migrations/*.sql and any SQL in subdirectories).

Applied to files:

• internal/database/migrations/046_add_cross_seed_custom_category.sql

📚 Learning: 2025-11-28T20:32:30.126Z

Learnt from: s0up4200
Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go:209-212
Timestamp: 2025-11-28T20:32:30.126Z
Learning: Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go
Learning: The cross-seed recheck-resume worker intentionally runs for the process lifetime and keys pending entries by hash only. This is acceptable under the current constraint that background seeded-search runs operate on a single instance at a time; graceful shutdown and instanceID|hash keying are deferred by design.

Applied to files:

• internal/models/crossseed.go

📚 Learning: 2025-11-06T12:11:04.963Z

Learnt from: Audionut
Repo: autobrr/qui PR: 553
File: internal/services/crossseed/service.go:1045-1082
Timestamp: 2025-11-06T12:11:04.963Z
Learning: The autobrr/qui project uses a custom go-qbittorrent client library (github.com/autobrr/go-qbittorrent) that supports both "paused" and "stopped" parameters when adding torrents via the options map. Both parameters should be set together when controlling torrent start state, as seen in internal/services/crossseed/service.go and throughout the codebase.

Applied to files:

• internal/models/crossseed.go
• docs/CROSS_SEEDING.md

📚 Learning: 2025-12-28T18:44:10.496Z

Learnt from: s0up4200
Repo: autobrr/qui PR: 876
File: internal/logstream/hub_test.go:188-192
Timestamp: 2025-12-28T18:44:10.496Z
Learning: In Go 1.25 (Aug 2025), use wg.Go(func()) to spawn a goroutine and automate the Add/Done lifecycle. Replace manual patterns like wg.Add(1); go func(){ defer wg.Done(); ... }() with wg.Go(func(){ ... }). Ensure the codebase builds with Go 1.25+ and apply this in relevant Go files (e.g., internal/logstream/hub_test.go). If targeting older Go versions, maintain the existing pattern.

Applied to files:

• internal/models/crossseed.go
• internal/services/crossseed/service.go
• internal/services/crossseed/auto_tmm_test.go

📚 Learning: 2025-11-28T22:21:20.730Z

Learnt from: s0up4200
Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go:2415-2457
Timestamp: 2025-11-28T22:21:20.730Z
Learning: Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go
Learning: The determineSavePath function intentionally includes a contentLayout string parameter for future/content-layout branching and API consistency. Its presence is by design even if unused in the current body; do not flag as an issue in reviews.

Applied to files:

• internal/services/crossseed/service.go

📚 Learning: 2025-12-03T18:11:08.682Z

Learnt from: finevan
Repo: autobrr/qui PR: 677
File: web/src/components/torrents/AddTorrentDialog.tsx:496-504
Timestamp: 2025-12-03T18:11:08.682Z
Learning: In the AddTorrentDialog component (web/src/components/torrents/AddTorrentDialog.tsx), temporary path settings (useDownloadPath/downloadPath) should be applied per-torrent rather than updating global instance preferences. The UI/UX is designed to suggest that these options apply to the individual torrent being added.

Applied to files:

• web/src/pages/CrossSeedPage.tsx

🧬 Code graph analysis (2)

web/src/components/ui/radio-group.tsx (1)

web/src/lib/utils.ts (1)

• cn (10-12)

web/src/pages/CrossSeedPage.tsx (5)

web/src/lib/category-utils.ts (1)

• buildCategorySelectOptions (9-33)

web/src/components/ui/radio-group.tsx (2)

• RadioGroup (42-42)
• RadioGroupItem (42-42)

web/src/components/ui/label.tsx (1)

• Label (29-29)

web/src/components/ui/tooltip.tsx (3)

• Tooltip (184-184)
• TooltipTrigger (184-184)
• TooltipContent (184-184)

web/src/components/ui/multi-select.tsx (1)

• MultiSelect (28-176)

🔇 Additional comments (16)

README.md (1)

432-436: Documentation clearly explains the three category modes.

The descriptions accurately reflect the implementation: suffix mode inherits AutoTMM, while indexer and custom modes disable it with explicit save paths.

web/src/components/ui/radio-group.tsx (1)

1-42: Well-structured RadioGroup component following established patterns.

The implementation follows the project's Radix UI wrapper conventions with proper forwardRef usage, accessibility-focused styling (focus-visible states, disabled handling), and correct displayName assignment.

docs/CROSS_SEEDING.md (1)

194-228: Comprehensive documentation of category modes and autoTMM behavior.

The table clearly communicates the autoTMM inheritance/disabled behavior per mode, and the explanations accurately reflect the implementation logic.

internal/services/crossseed/auto_tmm_test.go (1)

65-75: Good test coverage for the new useCustomCategory parameter.

The new test case correctly validates that custom category mode disables autoTMM even when all other conditions would enable it (matchedAutoManaged: true, useCategoryFromIndexer: false).

internal/database/migrations/046_add_cross_seed_custom_category.sql (1)

1-6: Migration follows SQLite conventions correctly.

The boolean column uses DEFAULT 0 instead of DEFAULT FALSE, which is the correct approach for SQLite consistency. Based on learnings, this aligns with the repository's migration standards.

internal/models/crossseed.go (2)

62-64: Model fields properly defined with appropriate types and JSON tags.

The new UseCustomCategory (bool) and CustomCategory (string) fields are correctly placed after the existing category-related fields, maintaining logical grouping.

---

539-545: INSERT statement columns and placeholders are aligned.

The INSERT statement has 38 columns and 38 placeholders on line 545—they match. No changes needed.

web/src/types/index.ts (2)

1667-1668: Type definitions correctly added to match backend model.

The useCustomCategory: boolean and customCategory: string fields align with the Go struct definitions in internal/models/crossseed.go.

---

1713-1714: Patch interface correctly uses optional modifiers.

The optional ? modifiers allow partial updates, consistent with the existing patch pattern used throughout the interface.

web/package.json (1)

35-35: LGTM - new Radix UI dependency for RadioGroup component.

The addition is consistent with the existing Radix UI primitives pattern used throughout the project, and v1.3.8 is the latest available version.

web/src/pages/CrossSeedPage.tsx (4)

23-23: Type definitions and defaults look good.

The new CategoryMode type, interface extensions, and default values are well-structured and properly typed for the three-way category mode system.

Also applies to: 77-78, 102-103, 128-129

---

1218-1232: Helper functions correctly enforce mutual exclusivity.

The getCategoryMode and setCategoryMode functions work together to maintain a consistent three-way exclusive state. The priority order (custom > indexer > suffix) in getCategoryMode provides a deterministic fallback if flags are somehow inconsistent.

---

1208-1215: Category options correctly sourced from all active instances.

Using webhookSourceMetadata (which aggregates categories from all active instances) provides comprehensive suggestions for the custom category dropdown, and the selected array parameter ensures the current value always appears.

---

2422-2495: RadioGroup UI implementation is well-structured and accessible.

The RadioGroup properly implements mutual exclusivity with good accessibility features (associated labels, aria-labels, tooltips), clear descriptions for each mode, and appropriate conditional rendering for the custom category input.

internal/services/crossseed/service.go (2)

7148-7192: shouldEnableAutoTMM: custom categories correctly treated like indexer categories

Extending autoTMMDecision with UseCustomCategory and updating shouldEnableAutoTMM to:

• accept useCustomCategory as a parameter, and
• require !useCategoryFromIndexer && !useCustomCategory to enable autoTMM,

ensures both indexer-based and custom-category modes always disable autoTMM, which is exactly what the new mode promises. Path-matching is still computed for observability via PathsMatch, without altering prior behavior.

---

7315-7351: determineCrossSeedCategory: custom category precedence and suffix behavior look correct

The new early branch:

if settings != nil && settings.UseCustomCategory && settings.CustomCategory != "" {
    return settings.CustomCategory, settings.CustomCategory
}

ensures:

• custom mode has highest precedence over request-level Category/IndexerName,
• the custom category is used as both base and cross category, and
• no .cross suffix is ever applied in that mode.

This aligns with the “mutually exclusive custom mode using an exact category” design and works cleanly with the downstream ensureCrossCategory + save-path logic.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Add validation for custom category when custom mode is selected.

The state initialization and patch building correctly handle the new fields, but there's no validation in handleSaveGlobal to ensure that customCategory is non-empty when useCustomCategory is true. This could allow saving an invalid configuration.

🔎 Suggested validation to add

Add validation in the handleSaveGlobal function (around line 1024):

 const handleSaveGlobal = () => {
   if (ignorePatternError) {
     setValidationErrors(prev => ({ ...prev, ignorePatterns: ignorePatternError }))
     return
   }
+
+  if (globalSettings.useCustomCategory && !globalSettings.customCategory.trim()) {
+    setValidationErrors(prev => ({ ...prev, customCategory: "Custom category name is required when custom mode is selected" }))
+    toast.error("Enter a custom category name or select a different category mode")
+    return
+  }

   if (validationErrors.ignorePatterns) {
     setValidationErrors(prev => ({ ...prev, ignorePatterns: "" }))
   }

Also applies to: 895-896, 922-923

🤖 Prompt for AI Agents

In web/src/pages/CrossSeedPage.tsx around lines 791-792 (and also the related
initialization at 895-896 and 922-923) the component allows useCustomCategory
true with an empty customCategory; add validation in handleSaveGlobal (around
line 1024) to check if formState.useCustomCategory is true then require
formState.customCategory.trim() to be non-empty; if empty, set an appropriate
user-visible error (or toast) and return early to prevent saving, and ensure the
same check is enforced before building the patch so invalid configs cannot be
submitted.

[onedr0p]

Closes: #904

[coderabbitai]

Actionable comments posted: 0

♻️ Duplicate comments (1)

web/src/pages/CrossSeedPage.tsx (1)

729-730: Add validation for custom category when custom mode is selected.

The state initialization and patch building correctly handle the new fields, but there's no validation in handleSaveGlobal to ensure that customCategory is non-empty when useCustomCategory is true. This could allow saving an invalid configuration.

🔎 Suggested validation to add

Add validation in the handleSaveGlobal function (around line 962):

 const handleSaveGlobal = () => {
   if (ignorePatternError) {
     setValidationErrors(prev => ({ ...prev, ignorePatterns: ignorePatternError }))
     return
   }
+
+  if (globalSettings.useCustomCategory && !globalSettings.customCategory.trim()) {
+    setValidationErrors(prev => ({ ...prev, customCategory: "Custom category name is required when custom mode is selected" }))
+    toast.error("Enter a custom category name or select a different category mode")
+    return
+  }

   if (validationErrors.ignorePatterns) {
     setValidationErrors(prev => ({ ...prev, ignorePatterns: "" }))
   }

Also applies to: 833-834, 860-861

🧹 Nitpick comments (1)

web/src/pages/CrossSeedPage.tsx (1)

238-243: Consider extracting InstanceFormState type to file level.

The type is currently defined inside the component. For consistency with other types in the file (like AutomationFormState, GlobalCrossSeedSettings), consider extracting it to the file level.

🔎 Optional refactor

+// Per-instance hardlink/reflink form state
+interface InstanceFormState {
+  useHardlinks: boolean
+  useReflinks: boolean
+  hardlinkBaseDir: string
+  hardlinkDirPreset: "flat" | "by-tracker" | "by-instance"
+}
+
 /** Per-instance hardlink/reflink mode settings component */
 function HardlinkModeSettings() {
   const { instances, updateInstance, isUpdating } = useInstances()
   const [expandedInstances, setExpandedInstances] = useState<string[]>([])
   const [dirtyMap, setDirtyMap] = useState<Record<number, boolean>>({})
-  type InstanceFormState = {
-    useHardlinks: boolean
-    useReflinks: boolean
-    hardlinkBaseDir: string
-    hardlinkDirPreset: "flat" | "by-tracker" | "by-instance"
-  }
   const [formMap, setFormMap] = useState<Record<number, InstanceFormState>>({})

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9a5d1e6 and 478f83b.

📒 Files selected for processing (1)

• web/src/pages/CrossSeedPage.tsx

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-12-03T18:11:08.682Z

Learnt from: finevan
Repo: autobrr/qui PR: 677
File: web/src/components/torrents/AddTorrentDialog.tsx:496-504
Timestamp: 2025-12-03T18:11:08.682Z
Learning: In the AddTorrentDialog component (web/src/components/torrents/AddTorrentDialog.tsx), temporary path settings (useDownloadPath/downloadPath) should be applied per-torrent rather than updating global instance preferences. The UI/UX is designed to suggest that these options apply to the individual torrent being added.

Applied to files:

• web/src/pages/CrossSeedPage.tsx

🧬 Code graph analysis (1)

web/src/pages/CrossSeedPage.tsx (6)

web/src/types/index.ts (1)

• Instance (19-36)

web/src/components/ui/radio-group.tsx (2)

• RadioGroup (42-42)
• RadioGroupItem (42-42)

web/src/components/ui/select.tsx (5)

• Select (180-180)
• SelectTrigger (188-188)
• SelectValue (189-189)
• SelectContent (181-181)
• SelectItem (183-183)

web/src/lib/category-utils.ts (1)

• buildCategorySelectOptions (9-33)

web/src/components/ui/tooltip.tsx (3)

• Tooltip (184-184)
• TooltipTrigger (184-184)
• TooltipContent (184-184)

web/src/components/ui/multi-select.tsx (1)

• MultiSelect (30-181)

🔇 Additional comments (5)

web/src/pages/CrossSeedPage.tsx (5)

102-103: LGTM! Clean type definition for category modes.

The CategoryMode union type provides type safety for the RadioGroup and helper functions.

---

77-78: LGTM! Interface and defaults are correctly defined.

The new fields are properly typed and initialized with sensible defaults.

Also applies to: 128-129

---

304-319: Excellent validation logic prevents invalid mode configurations.

The validation correctly checks for local filesystem access and base directory before enabling hardlink/reflink modes, preventing runtime issues.

---

1156-1170: LGTM! Category mode helpers are well-structured and type-safe.

The getCategoryMode and setCategoryMode functions correctly manage the mutual exclusivity of the three category mode flags. The priority order in getCategoryMode (custom > indexer > suffix) provides defensive handling if multiple flags are somehow true.

---

2360-2433: LGTM! Category mode UI is well-implemented with clear UX.

The RadioGroup properly exposes all three category modes with helpful tooltips explaining the behavior of each. The conditional MultiSelect for custom category supports both selection from existing categories and creation of new ones.

The use of MultiSelect for a single-value field is slightly unconventional (typically Select or ComboBox is used), but it works well here and the creatable feature provides good UX.