fix(web): column filter status now matches all states in category

[s0up4200]

Summary

• Fixes column filter status not properly filtering all states in a category
• Consolidates status options between ColumnFilterPopover and FilterSidebar
• Expands state categories to match all constituent qBittorrent states

Problem

When using the column filter to select "Is not" + "Seeding", the filter only generated:

string(State) != "uploading"

This only excluded torrents with the exact uploading state. Torrents in related seeding states (stalledUP, queuedUP, checkingUP, forcedUP) were still shown.

Solution

• Replace individual qBittorrent states in ColumnFilterPopover with grouped categories matching FilterSidebar
• Add STATE_CATEGORY_MAP that maps each category to its constituent states
• Modify columnFilterToExpr to expand categories when generating filter expressions

Now "Is not Seeding" generates:

(string(State) != "uploading" && string(State) != "stalledUP" && string(State) != "queuedUP" && string(State) != "checkingUP" && string(State) != "forcedUP")

Test plan

• Apply column filter with "Is" + "Seeding" - should show all seeding torrents
• Apply column filter with "Is not" + "Seeding" - should hide all seeding torrents (including stalled, queued, etc.)
• Verify "Completed" filter works (uses Progress == 1)
• Verify other status categories filter correctly

Fixes #824

Summary by CodeRabbit

• Improvements
  • Simplified torrent state filtering options with consolidated state groupings for clearer categorization.
  • Enhanced state filtering logic to properly handle grouped states and special conditions.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Consolidated torrent state filters into logical category groupings and implemented category-to-state expansion logic. When users filter by state categories (e.g., "seeding," "paused"), the filter now expands to include all constituent granular states for accurate matching, fixing incorrect filter results.

Changes

Cohort / File(s)	Summary
State Configuration and Consolidation web/src/components/torrents/ColumnFilterPopover.tsx	Replaced granular torrent states (forcedUP, forcedDL, pausedUP, pausedDL, etc.) with consolidated semantic categories (completed, stopped, paused, active, stalled, stalled_uploading, stalled_downloading, errored, checking). Added alignment comment with FilterSidebar.
State Filter Expansion Logic web/src/lib/column-filter-utils.ts	Introduced STATE_CATEGORY_MAP to map state categories to their constituent qBittorrent states. Extended columnFilterToExpr to expand state category filters: eq operators produce OR expressions across member states; ne operators produce AND expressions excluding all members. Added special "completed" handling mapping to Progress == 1.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• PR #796: Also modifies columnFilterToExpr in column-filter-utils.ts to add column remapping logic for seeds/peers filtering.
• PR #633: Also modifies TORRENT_STATES enum and state value handling in ColumnFilterPopover.tsx.

Suggested labels

bugfix, web, torrent

Poem

🐰 State filters once tangled, now clean and bright,
Categories bloom where granular states took flight,
"Not seeding" now truly means what it should,
Toggle and expand—filtering's understood! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: fixing column filter status behavior to match all states in a category, which is the core objective of the PR.
Linked Issues check	✅ Passed	The PR successfully addresses issue #824 by consolidating status categories, adding STATE_CATEGORY_MAP, and updating columnFilterToExpr to expand category selections into expressions that include all constituent states.
Out of Scope Changes check	✅ Passed	All changes are scoped to fixing the column filter status behavior: consolidating status options, introducing state category mapping, and updating filter expression logic to handle category expansion.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/column-filter-status-categories

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}