feat(crossseed): add source aliasing for WEB/WEB-DL/WEBRip precheck matching

[s0up4200]

Summary

• Add source normalization (WEB-DL → WEBDL, WEBRip → WEBRIP, WEB → WEB)
• Add sourcesCompatible() function for flexible web source matching
• Update releasesMatch() to use new source compatibility logic

Matching behavior:

• WEB ↔ WEB-DL ✓ (WEB is ambiguous)
• WEB ↔ WEBRip ✓ (WEB is ambiguous)
• WEB-DL ↔ WEBRip ✗ (explicitly different)
• WEB ↔ BluRay ✗ (non-web sources don't match)

This only affects the precheck gate (webhook /check). The final apply stage trusts file verification (size check + qBittorrent recheck) to catch real mismatches.

Test plan

• Added unit tests for normalizeSource()
• Added unit tests for sourcesCompatible()
• Added integration tests for releasesMatch() with source compatibility
• All existing crossseed tests pass

Summary by CodeRabbit

• Bug Fixes

  • Improved cross-seed source compatibility detection for web-based releases. Web sources (WEB, WEBDL, WEBRIP) now intelligently match based on compatibility rules, enabling more effective cross-seeding scenarios.

• Tests

  • Added comprehensive test coverage for source normalization and compatibility logic.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Refactored source matching logic in crossseed module to implement compatibility-based checking instead of strict equality. Replaces hard source equality with nuanced rules: web-based sources (WEB, WEBDL, WEBRIP) are compatible with special handling where WEB maps ambiguously to both WEBDL and WEBRIP, while WEBDL and WEBRIP don't match each other. Non-web sources require exact matches. Added normalization and compatibility helpers with comprehensive test coverage.

Changes

Cohort / File(s)	Summary
Source matching enhancement internal/services/crossseed/matching.go	Introduced sourceAliases map for canonical source forms; added normalizeSource() and sourcesCompatible() helpers implementing web-based source compatibility logic with special WEB ambiguity handling; updated releasesMatch() to use new compatibility gate; refactored joinNormalizedCodecSlice() to apply normalizeVideoCodec() consistently
Test coverage internal/services/crossseed/matching_source_test.go	New test file with three test suites: TestNormalizeSource validating normalization rules across case/hyphen scenarios; TestSourcesCompatible verifying compatibility logic for empty/exact/ambiguous/mismatch cases; TestReleasesMatch_SourceCompatibility exercising precheck matching across WEB/WEBDL/WEBRip/BluRay scenarios

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix(crossseed): treat x264/H.264/H264/AVC as equivalent codecs #766: Modifies codec normalization and joinNormalizedCodecSlice() in matching.go alongside source compatibility updates
• feat(crossseed): add Unicode normalization for title and file matching #742: Updates releasesMatch normalization/precheck logic with stringutils integration similar to source canonicalization approach
• fix(crossseed): improve matching with size validation and relaxed audio checks #845: Enhances releasesMatch with additional precheck validations including audio checks and size mismatches

Suggested labels

enhancement, cross-seed, tests

Poem

🐰 Web sources dance with grace so fine,
WEB ambiguous, WEBDL won't align,
Normalization rules, compatibility clear,
Crossseed matching's logic draws near!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 57.14% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: introducing source aliasing for WEB/WEB-DL/WEBRip matching in the crossseed feature's precheck logic.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/crossseed-web-source-aliasing

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

internal/services/crossseed/matching.go (1)

403-421: Source normalization looks good.

The normalization logic correctly handles standard release naming conventions. The implementation properly trims, uppercases, and maps variants to canonical forms.

💡 Optional: Add "WEB-RIP" alias for maximum robustness

While "WEBRip" (no hyphen) is the standard format and "WEB-DL" (with hyphen) is standard for that variant, adding a "WEB-RIP" entry would defensively handle any non-standard naming:

 var sourceAliases = map[string]string{
 	"WEB-DL": "WEBDL",
 	"WEBDL":  "WEBDL",
+	"WEB-RIP": "WEBRIP",
 	"WEBRIP": "WEBRIP",
 	"WEB":    "WEB",
 }

This is a minor defensive improvement and not critical given real-world naming conventions.

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 57650e8 and 760769e.

📒 Files selected for processing (2)

• internal/services/crossseed/matching.go
• internal/services/crossseed/matching_source_test.go

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-11-28T20:32:30.126Z

Learnt from: s0up4200
Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go:209-212
Timestamp: 2025-11-28T20:32:30.126Z
Learning: Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go
Learning: The cross-seed recheck-resume worker intentionally runs for the process lifetime and keys pending entries by hash only. This is acceptable under the current constraint that background seeded-search runs operate on a single instance at a time; graceful shutdown and instanceID|hash keying are deferred by design.

Applied to files:

• internal/services/crossseed/matching_source_test.go

🧬 Code graph analysis (1)

internal/services/crossseed/matching_source_test.go (1)

pkg/stringutils/normalize.go (1)

• NewDefaultNormalizer (35-37)

🔇 Additional comments (5)

internal/services/crossseed/matching.go (2)

229-237: LGTM! Clear implementation of source compatibility logic.

The inline comments effectively document the WEB ambiguity behavior and the distinction between precheck matching (this stage) versus file verification (apply stage). The delegation to normalizeSource() and sourcesCompatible() keeps the main matching logic clean and readable.

---

423-453: Excellent implementation of the source compatibility logic.

The function correctly implements the documented behavior:

• Empty sources are treated as compatible (flexible matching)
• Exact matches pass through immediately
• WEB is treated as ambiguous and matches both WEBDL and WEBRIP
• WEBDL and WEBRIP are explicitly incompatible with each other
• Non-web sources must match exactly

The early-return structure and inline helper keep the logic clear and efficient.

internal/services/crossseed/matching_source_test.go (3)

12-44: Well-structured normalization tests with good coverage.

The test cases cover the main source variants (WEB-DL, WEBDL, WEBRIP, WEB) with different case variations, plus passthrough behavior for non-web sources. The table-driven approach makes the tests clear and easy to extend.

---

46-87: Comprehensive compatibility test coverage.

The test suite validates all documented compatibility rules including:

• Empty source handling
• Exact match behavior
• WEB ambiguity (matches both WEBDL and WEBRIP)
• WEBDL vs WEBRIP explicit incompatibility
• Non-web source requirements

The bidirectional tests (e.g., WEB→WEBDL and WEBDL→WEB) ensure symmetry in the matching logic.

---

89-240: Excellent integration test coverage for source compatibility.

These tests validate that the source compatibility logic integrates correctly with the full releasesMatch() function. By holding other release attributes constant (title, year, resolution, group) and varying only the source field, the tests cleanly isolate and verify the new matching behavior.

The test cases align perfectly with the documented matching rules from the PR objectives, and the descriptive names and inline descriptions make the intent clear.