feat(crossseed): add option to skip recheck-required matches

[s0up4200]

Summary

• Add skipRecheck setting to skip cross-seed matches requiring disk verification
• Applies to all cross-seed sources: RSS automation, completion search, seeded search, and webhooks
• Helps users on shared hosting or constrained hardware avoid heavy disk I/O

Test plan

• Enable "Skip recheck-required matches" in Cross-Seed settings
• Trigger a cross-seed that requires rename alignment or has extra files
• Verify it shows "Skipped - recheck required" status instead of adding the torrent
• Verify cross-seeds that don't require recheck still work normally

Closes #820

Summary by CodeRabbit

• New Features
  • Added a toggle in automation settings to skip cross-seed matches requiring manual rechecks (such as those needing rename alignment or extra file handling).
  • Added status display for cross-seed operations skipped due to recheck requirements.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

This PR adds a new SkipRecheck boolean flag to CrossSeed automation settings, enabling users to skip torrent rechecks when cross-seed matches are found. The flag is threaded through the database schema, backend models, API handlers, service layer, and frontend UI, with conditional logic to apply the skip behavior in the service.

Changes

Cohort / File(s)	Summary
Database Migration internal/database/migrations/035_add_cross_seed_skip_recheck.sql	Adds non-null boolean column skip_recheck (default false) to cross_seed_settings table.
Backend Models & Data Layer internal/models/crossseed.go	Adds SkipRecheck bool field to CrossSeedAutomationSettings struct; updates DefaultCrossSeedAutomationSettings() initialization; threads field through SQL in GetSettings() and UpsertSettings() for read/write operations.
API Handler internal/api/handlers/crossseed.go	Adds SkipRecheck field to request/patch payloads (automationSettingsRequest, automationSettingsPatchRequest); updates isEmpty() logic; threads value through UpdateAutomationSettings and applyAutomationSettingsPatch.
Service Layer internal/services/crossseed/...	Adds SkipRecheck bool option to SearchRunOptions; propagates flag through CrossSeedRequest model; introduces conditional to skip recheck when flag is true and operation requires alignment or has extra files; plumbs flag across Completion search, RSS/autobrr apply, manual apply, and search path entry points.
API Documentation internal/web/swagger/openapi.yaml	Adds skipRecheck boolean field to CrossSeedAutomationSettings and CrossSeedAutomationSettingsPatch schemas in OpenAPI spec.
Frontend Types & Pages web/src/types/index.ts, web/src/pages/CrossSeedPage.tsx	Adds skipRecheck: boolean field to TypeScript CrossSeedAutomationSettings and CrossSeedAutomationSettingsPatch interfaces; adds skipRecheck property to GlobalCrossSeedSettings interface with default value false; wires field through patch builders and settings initialization; adds UI toggle "Skip recheck-required matches" to Global Cross-Seed Settings panel.
Frontend Components web/src/components/torrents/CrossSeedDialog.tsx	Adds handling for new instance status "skipped_recheck" in status display mapper, returning "Skipped - recheck required" with destructive variant styling.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

The changes follow a consistent, repetitive pattern across multiple layers (field addition + threading through data access paths). While touching 9 files across multiple domains (backend, database, service, frontend, types), each individual modification is straightforward. The service layer conditional logic is simple. Verify that:

• The SkipRecheck field is correctly threaded through all request/patch payloads and database operations
• The conditional logic in service.go correctly identifies when to skip recheck (alignment required or extra files present)
• The UI toggle correctly binds to and updates the global settings payload

Possibly related PRs

• feat(crossseed): add skip auto-resume settings per mode #755: Adds another per-settings boolean flag (SkipAutoResume*) to the same automation settings API structs and patch/apply logic.
• feat(crossseed): add RSS source filters for categories and tags #757: Modifies the same CrossSeed automation settings plumbing in internal/api/handlers/crossseed.go (isEmpty, applyAutomationSettingsPatch) to add new boolean fields.
• feat(cross-seed): add PATCH support for scoped settings saves #614: Extends CrossSeed automation settings with a new field and threads it through API handler, model, DB, service, and UI with the same patch/merge logic patterns.

Suggested labels

enhancement, database:migrations, cross-seed, web, api, backend

Poem

🐰 A hoppy flag floats down the stack,
Through database rows and UI black,
When recheck's skip rings loud and clear,
Poor hardware users raise a cheer!
No hour-long checks on drives so vast—
Just swift cross-seeding at last! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely describes the main feature being added: a new option to skip recheck-required matches in cross-seed processing.
Linked Issues check	✅ Passed	The PR successfully implements the feature request from issue #820 by adding a skipRecheck setting across all cross-seed sources (RSS, completion, seeded search, webhooks) with proper UI toggle and status display.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to implementing the skipRecheck feature: database schema, models, API handlers, service logic, UI components, and type definitions. No unrelated modifications detected.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/crossseed-skip-recheck

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

internal/services/crossseed/service.go (1)

1895-1904: Treat skipped_recheck as a skipped outcome in RSS automation, not a failure

The new logic in processCrossSeedCandidate:

• Early-returns with Status = "skipped_recheck" when req.SkipRecheck && (requiresAlignment || hasExtraFiles), correctly avoiding both AddTorrent and any disk recheck.
• Suppresses the AddTorrent “retry with recheck” fallback when req.SkipRecheck is true, which aligns with the feature’s intent to never trigger recheck-driven I/O.

However, in processAutomationCandidate the RSS automation aggregation still routes unknown statuses (including skipped_recheck) through the default branch:

switch instanceResult.Status {
case "exists":
    ...
case "no_match", "skipped":
    run.TorrentsSkipped++
default:
    itemHasFailure = true
    run.TorrentsFailed++
}

That will count explicitly skipped-for-recheck items as failures, which can flip runs to Failed/Partial even though everything worked as configured and the test plan expects a “Skipped - recheck required” style outcome.

Recommend classifying skipped_recheck alongside the other skipped statuses:

Proposed fix: classify skipped_recheck as skipped

-       switch instanceResult.Status {
-       case "exists":
-           itemHadExisting = true
-           run.TorrentsSkipped++
-       case "no_match", "skipped":
-           run.TorrentsSkipped++
-       default:
-           itemHasFailure = true
-           run.TorrentsFailed++
-       }
+       switch instanceResult.Status {
+       case "exists":
+           itemHadExisting = true
+           run.TorrentsSkipped++
+       case "no_match", "skipped", "skipped_recheck":
+           run.TorrentsSkipped++
+       default:
+           itemHasFailure = true
+           run.TorrentsFailed++
+       }

This keeps RSS automation run statistics and overall status aligned with the new SkipRecheck feature while preserving existing behavior for genuine errors.

Also applies to: 2562-2668, 2898-2909

🧹 Nitpick comments (1)

internal/services/crossseed/models.go (1)

45-46: SkipRecheck flag wiring looks good; consider refreshing status doc comment

The new SkipRecheck field and json:"skip_recheck,omitempty" tag fit the existing request shape and default safely to false for callers that don’t know about it yet.

Minor nit: the InstanceCrossSeedResult.Status comment still only lists "added", "exists", "no_match", "error", while the code/UX now handle additional values like no_save_path, invalid_content_path, and skipped_recheck. Consider updating the comment so future contributors see the full set of expected statuses.

Optional doc tweak

-	// Status describes the result: "added", "exists", "no_match", "error"
+	// Status describes the result: "added", "exists", "no_match", "no_save_path",
+	// "invalid_content_path", "skipped_recheck", "error", or other internal status codes.
 	Status  string `json:"status"`

Also applies to: 73-83

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e9fcbda and d9c0bf5.

📒 Files selected for processing (9)

• internal/api/handlers/crossseed.go (5 hunks)
• internal/database/migrations/035_add_cross_seed_skip_recheck.sql (1 hunks)
• internal/models/crossseed.go (7 hunks)
• internal/services/crossseed/models.go (1 hunks)
• internal/services/crossseed/service.go (11 hunks)
• internal/web/swagger/openapi.yaml (2 hunks)
• web/src/components/torrents/CrossSeedDialog.tsx (1 hunks)
• web/src/pages/CrossSeedPage.tsx (6 hunks)
• web/src/types/index.ts (2 hunks)

🧰 Additional context used

🧠 Learnings (6)

📓 Common learnings

Learnt from: s0up4200
Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go:209-212
Timestamp: 2025-11-28T20:32:30.126Z
Learning: Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go
Learning: The cross-seed recheck-resume worker intentionally runs for the process lifetime and keys pending entries by hash only. This is acceptable under the current constraint that background seeded-search runs operate on a single instance at a time; graceful shutdown and instanceID|hash keying are deferred by design.

📚 Learning: 2025-11-28T20:32:30.126Z

Learnt from: s0up4200
Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go:209-212
Timestamp: 2025-11-28T20:32:30.126Z
Learning: Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go
Learning: The cross-seed recheck-resume worker intentionally runs for the process lifetime and keys pending entries by hash only. This is acceptable under the current constraint that background seeded-search runs operate on a single instance at a time; graceful shutdown and instanceID|hash keying are deferred by design.

Applied to files:

• internal/services/crossseed/models.go
• web/src/types/index.ts
• internal/models/crossseed.go
• internal/services/crossseed/service.go
• internal/api/handlers/crossseed.go

📚 Learning: 2025-11-28T22:21:20.730Z

Learnt from: s0up4200
Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go:2415-2457
Timestamp: 2025-11-28T22:21:20.730Z
Learning: Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go
Learning: The determineSavePath function intentionally includes a contentLayout string parameter for future/content-layout branching and API consistency. Its presence is by design even if unused in the current body; do not flag as an issue in reviews.

Applied to files:

• internal/services/crossseed/models.go
• internal/services/crossseed/service.go

📚 Learning: 2025-12-03T18:11:08.682Z

Learnt from: finevan
Repo: autobrr/qui PR: 677
File: web/src/components/torrents/AddTorrentDialog.tsx:496-504
Timestamp: 2025-12-03T18:11:08.682Z
Learning: In the AddTorrentDialog component (web/src/components/torrents/AddTorrentDialog.tsx), temporary path settings (useDownloadPath/downloadPath) should be applied per-torrent rather than updating global instance preferences. The UI/UX is designed to suggest that these options apply to the individual torrent being added.

Applied to files:

• web/src/components/torrents/CrossSeedDialog.tsx

📚 Learning: 2025-11-06T12:11:04.963Z

Learnt from: Audionut
Repo: autobrr/qui PR: 553
File: internal/services/crossseed/service.go:1045-1082
Timestamp: 2025-11-06T12:11:04.963Z
Learning: The autobrr/qui project uses a custom go-qbittorrent client library (github.com/autobrr/go-qbittorrent) that supports both "paused" and "stopped" parameters when adding torrents via the options map. Both parameters should be set together when controlling torrent start state, as seen in internal/services/crossseed/service.go and throughout the codebase.

Applied to files:

• internal/services/crossseed/service.go

📚 Learning: 2025-11-25T22:46:03.762Z

Learnt from: s0up4200
Repo: autobrr/qui PR: 632
File: internal/backups/service.go:1401-1404
Timestamp: 2025-11-25T22:46:03.762Z
Learning: In qui's backup service (internal/backups/service.go), background torrent downloads initiated during manifest import intentionally use a fire-and-forget pattern with the shared service context (s.ctx). Per-run cancellation is not needed, as orphaned downloads completing after run deletion are considered harmless and acceptable. This design prioritizes simplicity over per-run lifecycle management for background downloads.

Applied to files:

• internal/services/crossseed/service.go

🧬 Code graph analysis (1)

web/src/pages/CrossSeedPage.tsx (2)

web/src/components/ui/label.tsx (1)

• Label (29-29)

web/src/components/ui/switch.tsx (1)

• Switch (34-34)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Run tests

🔇 Additional comments (20)

web/src/components/torrents/CrossSeedDialog.tsx (1)

540-541: New skipped_recheck status mapping is consistent and clear

The "skipped_recheck" branch cleanly surfaces the new outcome with an explicit “Skipped - recheck required” label and a high‑visibility variant, which aligns with how other non-success outcomes are presented.

internal/database/migrations/035_add_cross_seed_skip_recheck.sql (1)

1-1: Migration adds skip_recheck safely

Adding skip_recheck BOOLEAN NOT NULL DEFAULT 0 ensures all existing cross_seed_settings rows get a safe default of false and keeps future rows non-nullable. This looks straightforward and compatible with the new automation setting.

web/src/types/index.ts (1)

1410-1447: Type additions for skipRecheck correctly mirror the API

skipRecheck is required on CrossSeedAutomationSettings and optional on CrossSeedAutomationSettingsPatch, which matches the PUT vs PATCH semantics and the backend JSON field name. This should let the UI both display and modify the new flag without type mismatches.

Also applies to: 1449-1484

internal/api/handlers/crossseed.go (2)

31-46: Request/patch structs cleanly expose SkipRecheck

The additions of SkipRecheck on automationSettingsRequest and *SkipRecheck on automationSettingsPatchRequest, plus the update to isEmpty(), mean clients can now both fully set and selectively patch this flag. JSON tag skipRecheck matches the schema and web types, so decoding will be consistent across layers.

Also applies to: 48-84, 142-175

---

176-283: SkipRecheck is correctly merged into persisted automation settings

applyAutomationSettingsPatch now applies patch.SkipRecheck to settings.SkipRecheck when present, and UpdateAutomationSettings initializes SkipRecheck from the PUT request. This keeps the new flag flowing end-to-end through the API into models.CrossSeedAutomationSettings without affecting existing validation logic.

Also applies to: 647-662

internal/web/swagger/openapi.yaml (1)

3959-3962: OpenAPI schemas for skipRecheck are aligned and descriptive

Adding skipRecheck to both CrossSeedAutomationSettingsPatch and CrossSeedAutomationSettings with a clear description keeps the API contract in sync with the handler, models, and frontend types, and documents the new behavior for generated clients and users.

Also applies to: 4025-4027

internal/services/crossseed/service.go (2)

429-450: SkipRecheck plumbing through search/completion options looks consistent

SearchRunOptions.SkipRecheck plus its use in executeCompletionSearch and StartSearchRun correctly propagate the automation-level setting into all seeded-search/completion paths, mirroring how StartPaused and SkipAutoResume* are handled. No functional concerns here.

Also applies to: 1132-1143, 1188-1229

---

2488-2511: Entry-point wiring of SkipRecheck into CrossSeedRequest is coherent

The additional skipRecheck local in AutobrrApply, the similar wiring in ApplyTorrentSearchResults, and the SkipRecheck field passed from searchRunState.opts in executeCrossSeedSearchAttempt all correctly route the global automation setting into CrossSeedRequest. This keeps behavior consistent across autobrr webhooks, manual apply, and seeded search runs without introducing new edge cases.

Also applies to: 4638-4853, 5836-5882

internal/models/crossseed.go (7)

68-68: LGTM! Field addition is well-placed.

The SkipRecheck field is logically grouped with other skip settings and follows consistent naming conventions.

---

122-122: LGTM! Safe default value.

Setting SkipRecheck to false by default preserves existing behavior and makes this an opt-in feature, which is appropriate for a new capability that changes cross-seed processing.

---

302-302: LGTM! Query correctly extended.

The skip_recheck column is properly added to the SELECT query following database naming conventions.

---

350-350: LGTM! Scan operation is correct.

The scan correctly reads skip_recheck into settings.SkipRecheck, maintaining alignment with the SELECT query.

---

555-556: LGTM! UPDATE clause correctly modified.

The skip_recheck column is properly added to the ON CONFLICT DO UPDATE clause with correct syntax.

---

602-602: LGTM! Parameter correctly bound.

The settings.SkipRecheck value is properly passed to ExecContext in the correct position.

---

520-523: The placeholder count verification is complete. The VALUES clause contains 32 placeholders, and the ExecContext call passes exactly 32 parameters, including the newly added settings.SkipRecheck parameter. The counts match correctly.

web/src/pages/CrossSeedPage.tsx (5)

87-87: LGTM! Interface correctly extended.

The skipRecheck field is properly typed and logically grouped with other skip settings.

---

131-131: LGTM! Default value is consistent.

The frontend default value matches the backend, ensuring consistency across the stack.

---

437-437: LGTM! Safe initialization with proper fallback.

The nullish coalescing operator ensures a safe default if the API doesn't return the field, which is good defensive programming.

---

533-533: LGTM! Patch builder correctly includes the field.

The skipRecheck field is properly included in both the fallback source and the final patch object, maintaining consistency with other skip settings.

Also applies to: 558-558

---

2118-2136: LGTM! Clear and well-structured UI section.

The new "Recheck behavior" panel follows existing patterns and provides clear labeling. The helper text "Skip matches needing rename alignment or extra files" accurately describes the scenarios mentioned in the PR objectives.

The placement after auto-resume settings is logical, as both control post-match behavior.