fix(rss): populate legacy assignedCategory for qBittorrent < 5.0 comp…

[frrad]

Summary

• qBittorrent versions before 5.0 use flat fields (assignedCategory, savePath) on RSS auto-download rules and silently ignore the torrentParams nested object
• When a user sets a category in the RSS rules editor, the frontend sends torrentParams.category but older qBittorrent instances discard it, causing the save to silently fail
• Fix: in SetRSSRule, mirror TorrentParams.Category → AssignedCategory and TorrentParams.SavePath → SavePath before forwarding to qBittorrent, so both old and new instances receive the data in a format they understand

discussion about bug: #1707

Testing

Like I mentioned in the discussion, I have simulated this fix by editing the curl and verifying that it works for me, but I haven't actually run patch. Also have not verified it doesn't cause issues with more recent qbittorrent versions.

Generated by Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Improved compatibility with older qBittorrent versions when setting RSS rules. Category and save path assignments now properly persist across qBittorrent instances that use legacy configuration handling.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8d7536c7-d3ef-4b4f-9bcd-96d6a17233e5

📥 Commits

Reviewing files that changed from the base of the PR and between dd661e8 and 12ce9ad.

📒 Files selected for processing (1)

• internal/qbittorrent/sync_manager.go

---

Walkthrough

SetRSSRule is enhanced with a compatibility shim for older qBittorrent versions. When rule.TorrentParams is present, the function mirrors its Category and SavePath fields into the legacy rule fields before persisting them via the API call.

Changes

qBittorrent Compatibility Shim

Layer / File(s)	Summary
Core Compatibility Logic internal/qbittorrent/sync_manager.go	Added conditional field-mirroring in SetRSSRule: if rule.TorrentParams is non-nil, copy TorrentParams.Category → rule.AssignedCategory and TorrentParams.SavePath → rule.SavePath before API call to ensure older qBittorrent versions persist these fields.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

bugfix

Poem

🐰 A tiny patch hops into place,
Old qBittorrent now shows its face!
Copy fields with care and grace,
Legacy rules get their rightful space. ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main fix: populating legacy assignedCategory field for qBittorrent < 5.0 compatibility, which aligns with the primary change of compensating for older qBittorrent versions that don't honor TorrentParams.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}