fix(automations): include AutoManagement in delete standalone check

[nitrobass24]

Summary

• Adds AutoManagement to the hasOtherAction check in validatePayload so that Delete + AutoManagement is rejected as invalid

The delete-is-standalone validation already checks SpeedLimits, ShareLimits, Pause, Resume, Recheck, Reannounce, Tags, Category, Move, and ExternalProgram — but AutoManagement was missed when it was added in ba3d5d9.

#1726 fixed the other three validation functions (conditionsUseField, conditionTreesForValidation, collectConditionRegexErrors) but this one was still missing.

Test plan

• go test -race -count=1 -v ./internal/api/handlers/... passes

Summary by CodeRabbit

• Bug Fixes
  • Automation validation updated: Auto Management options can no longer be combined with an enabled Delete action. This prevents conflicting automation setups and reduces risk of unintended deletions; users configuring automations will now see the validation enforced when attempting such combinations.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f821df58-c86a-4b93-93d8-b0a3829991f1

📥 Commits

Reviewing files that changed from the base of the PR and between 0545db8 and 36a487f.

📒 Files selected for processing (1)

• internal/api/handlers/automations.go

✅ Files skipped from review due to trivial changes (1)

• internal/api/handlers/automations.go

---

Walkthrough

The automations handler's validatePayload now treats an enabled AutoManagement condition as an "other action" that cannot be combined with an enabled Delete action, by adding it to the hasOtherAction boolean check.

Changes

Cohort / File(s)	Summary
Validation Enhancement internal/api/handlers/automations.go	Extended validatePayload so that hasOtherAction also becomes true when payload.Conditions.AutoManagement is present, preventing Delete from being combined with AutoManagement alongside existing incompatible actions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A gentle check in code I sow,
AutoManagement won't mix with "go",
Delete stands firm, alone and neat,
Rules aligned in tidy seat,
A hop, a fix — the logic's sweet!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding AutoManagement to the delete standalone validation check.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/automations-autotmm-delete-validation

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@internal/api/handlers/automations.go`:
- Line 359: The hasOtherAction check currently treats
payload.Conditions.AutoManagement as enabled only when AutoManagement != nil &&
AutoManagement.Enabled; change it to consider AutoManagement as active whenever
it is non-nil (i.e., remove the .Enabled check) so the delete vs AutoManagement
conflict logic matches the repo convention where non-nil AutoManagement means
enabled; update the condition that references payload.Conditions.AutoManagement
and any related logic in hasOtherAction to use AutoManagement != nil instead of
checking .Enabled.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ecd837db-d0ce-48ae-a72f-a580b3ba9453

📥 Commits

Reviewing files that changed from the base of the PR and between 3fbcc7a and 0545db8.

📒 Files selected for processing (1)

• internal/api/handlers/automations.go

[nitrobass24]

This is a follow on to PR #1726