fix(crossseed): skip link-mode category path warnings

[s0up4200]

Hardlink and reflink cross-seeds are added with an explicit savepath and autoTMM=false, so an existing qBittorrent category save_path mismatch is not actionable there. This change keeps the regular-mode warning, but stops treating that mismatch as noteworthy in link modes.

It keeps the category existence check for link modes while limiting save-path mismatch warnings to the regular flow where the category path is still relevant.

Summary by CodeRabbit

• Bug Fixes

  • Cross-seed category handling now validates save paths in regular mode to detect mismatches and prevent inconsistencies, while hardlink and reflink modes maintain flexible path configurations.

• Tests

  • Expanded test coverage for cross-seed category save path validation scenarios across different operational modes.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 080944ec-f693-497b-b3c6-d52f501a5c4a

📥 Commits

Reviewing files that changed from the base of the PR and between 5262f7c and e9176a7.

📒 Files selected for processing (2)

• internal/services/crossseed/category_cache_test.go
• internal/services/crossseed/service.go

---

Walkthrough

The changes extend the ensureCrossCategory function with a new boolean parameter to conditionally control save-path validation and mismatch warning behavior, with different modes applying this flag based on operational context (regular vs. hardlink/reflink).

Changes

Cohort / File(s)	Summary
Test Updates internal/services/crossseed/category_cache_test.go	Updated all existing test calls to ensureCrossCategory to include the new compareExistingSavePath boolean parameter; added new test TestShouldWarnOnCategorySavePathMismatch with table-driven cases covering regular-mode warnings, link-mode bypass, exact matches, and missing paths.
Service Implementation internal/services/crossseed/service.go	Extended ensureCrossCategory signature with compareExistingSavePath bool parameter; added helper function shouldWarnOnCategorySavePathMismatch for normalized path comparison and warning logic; updated call sites to pass true for regular mode and false for hardlink/reflink modes; conditional early return logic based on flag to skip path equivalence requirements.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix(cross-seed): use correct save path for tracker-named categories in reflink/hardlink mode #1710: Directly modifies ensureCrossCategory behavior with save-path handling and skip logic for reflink/hardlink modes similarly to this PR.
• fix(crossseed): resolve category creation race condition and relax autoTMM #767: Modifies ensureCrossCategory implementation with different deduplication and tracking approaches affecting the same function's flow.
• fix(crossseed): inherit TMM state from matched torrent #654: Changes cross-seed category and save-path handling logic in ensureCrossCategory and related decision-making.

Suggested labels

bugfix, cross-seed

Poem

🐰 A flag hops into sight,
Paths checked or skipped outright,
In link-mode we run free,
While regular paths decree:
Mismatches must warn and warn.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: skipping category path warnings for link-mode cross-seeds, which aligns with the PR's primary objective.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/crossseed-link-mode-category-log

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}