fix: manifests/quick-start/sso for running locally PROFILE=sso #6503

shioshiota · 2021-08-07T14:27:01Z

Signed-off-by: Tetsuya Shiota tetsuya.shiota.1231@gmail.com

Checklist:

My organization is added to USERS.md.

Tips:

Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
Sign-off your commits to pass the DCO check: git commit --signoff.
Run make pre-commit -B to fix codegen or lint problems.
Say how how you tested your changes. If you changed the UI, attach screenshots.

I noticed that make start PROFILE=sso didn't work well.
That is caused by the UI server launched by the command listens on :8080 but the redirect URI for dex configured to http://localhost:2746/oauth2/callback.
This PR fixed it.
https://github.com/argoproj/argo-workflows/blob/a3fd704a1715900f2144c0362e562f75f1524126/docs/running-locally.md

Signed-off-by: Tetsuya Shiota <tetsuya.shiota.1231@gmail.com>

alexec · 2021-08-09T20:34:30Z

manifests/quick-start/sso/dex/dex-cm.yaml

@@ -15,7 +15,7 @@ data:
    staticClients:
      - id: argo-server
        redirectURIs:
-          - http://localhost:2746/oauth2/callback
+          - http://localhost:8080/oauth2/callback


this is wrong, sorry, it should be 2746

I know that UI runs on 8080

If it is left to be 2746, the dex server returns an Unregistered redirect_uri error when I use SSO login with web UI.

Should I not update but add 8080 to URIs?

fix it: ad02c18

wrong

codecov · 2021-08-09T21:01:13Z

Codecov Report

Merging #6503 (7d9bbe3) into master (a3fd704) will increase coverage by 0.19%.
The diff coverage is 85.29%.

❗ Current head 7d9bbe3 differs from pull request most recent head ad02c18. Consider uploading reports for the commit ad02c18 to get more accurate results

@@            Coverage Diff             @@
##           master    #6503      +/-   ##
==========================================
+ Coverage   48.43%   48.62%   +0.19%     
==========================================
  Files         260      260              
  Lines       18804    18827      +23     
==========================================
+ Hits         9108     9155      +47     
+ Misses       8691     8665      -26     
- Partials     1005     1007       +2

Impacted Files	Coverage Δ
workflow/util/util.go	`46.26% <0.00%> (+1.11%)`	⬆️
util/kubeconfig/kubeconfig.go	`31.01% <87.87%> (+11.50%)`	⬆️
cmd/argo/commands/get.go	`59.18% <0.00%> (+0.87%)`	⬆️
cmd/argoexec/commands/emissary.go	`51.79% <0.00%> (+1.43%)`	⬆️
server/workflow/workflow_server.go	`46.80% <0.00%> (+2.39%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3fd704...ad02c18. Read the comment docs.

Signed-off-by: Tetsuya Shiota <tetsuya.shiota.1231@gmail.com>

alexec · 2021-08-20T14:29:53Z

I think this would break for users running on 2746

shioshiota · 2021-08-24T11:50:28Z

I updated the configuration of dex to allow ports both 2746 and 8080.
ad02c18

…rgoproj#3523, argoproj#2063 Signed-off-by: Alex Collins <alex_collins@intuit.com> mre Signed-off-by: Alex Collins <alex_collins@intuit.com> bits Signed-off-by: Alex Collins <alex_collins@intuit.com> fix(executor): Disambiguate PNS executor initialization log (argoproj#6582) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> ci: Disable builds on forks (argoproj#6589) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> fix!: Enable authentication by default on Argo Server `/metrics` endpoint. Fixes argoproj#6592 (argoproj#6595) Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> chore: Upgrade cobra to v1.2.1 (argoproj#6597) Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: Document auth rate limiting. Fixes argoproj#5217 docs: Document IP address logging. Fixes argoproj#5216 fix: Fix `gosec` warnings, disable pprof by default. Fixes argoproj#6594 (argoproj#6596) Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> fix tests Signed-off-by: Alex Collins <alex_collins@intuit.com> fix/skip tests Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> o Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: Fix template-defaults duplicated in docs and add missing whitespace in h1 (argoproj#6601) Signed-off-by: Michael Pöllath <mpoellath.dev@gmail.com> docs: fix continue on failure dag example (argoproj#6609) Signed-off-by: Siebren Zwerver <siebren@siebjee.nl> fix: manifests/quick-start/sso for running locally PROFILE=sso (argoproj#6503) Signed-off-by: Tetsuya Shiota <tetsuya.shiota.1231@gmail.com> chore: Run `make codegen` Signed-off-by: Alex Collins <alex_collins@intuit.com> build: disable UI by default for `make start` docs: Document argoproj#6297 breaking change (argoproj#6616) docs: Remove sym-links from docs (argoproj#6617) Signed-off-by: Alex Collins <alex_collins@intuit.com> upgrade to v0.0.9 Signed-off-by: Alex Collins <alex_collins@intuit.com> fix test Signed-off-by: Alex Collins <alex_collins@intuit.com> fix tests Signed-off-by: Alex Collins <alex_collins@intuit.com> add missing label selector Signed-off-by: Alex Collins <alex_collins@intuit.com> add transport wrappers Signed-off-by: Alex Collins <alex_collins@intuit.com> fix clean-up keys Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> fix: quay.io stuffs Signed-off-by: Alex Collins <alex_collins@intuit.com> fix: support in-cluster correctly Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> fix(controller): Initialize throttler during starting workflow-controller. Fixes: argoproj#6599 (argoproj#6608) Signed-off-by: smile-luobin <smile.luobin@gmail.com> docs: Add slack exit handler example. Resolves argoproj#4152 (argoproj#6612) Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com> fix: Argo Workflow specs link to not go to raw content (argoproj#6624) Signed-off-by: Andrey Melnikov <vafilor@gmail.com> ci: Build Docker manifest with complete dep list (argoproj#6621) Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> fix: Upgrade Dataflow to v0.0.96 (argoproj#6622) Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: Fix incorrect link to examples (argoproj#6630) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> fix: Fixed typo in clusterrole (argoproj#6626) Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com> build: Fix repository prefix (argoproj#6636) Signed-off-by: Alex Collins <alex_collins@intuit.com> feat: Upgrade dataflow to v0.0.98 (argoproj#6637) Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: correct https://bit.ly/book-30m-with-argo-team URL feat(controller): Add a shared index informer for ConfigMaps (argoproj#6644) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Fix duplicated import Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>

fix: quick-start/sso for running locally PROFILE=sso

b40e7b6

Signed-off-by: Tetsuya Shiota <tetsuya.shiota.1231@gmail.com>

alexec enabled auto-merge (squash) August 9, 2021 20:34

alexec previously approved these changes Aug 9, 2021

View reviewed changes

alexec reviewed Aug 9, 2021

View reviewed changes

alexec disabled auto-merge August 9, 2021 20:34

fix: redirectURIs supports both 8080 and 2746 port

ad02c18

Signed-off-by: Tetsuya Shiota <tetsuya.shiota.1231@gmail.com>

shioshiota force-pushed the fix-quick-start-sso branch from 9a683db to ad02c18 Compare August 10, 2021 01:22

shioshiota requested a review from alexec August 24, 2021 11:50

alexec approved these changes Aug 26, 2021

View reviewed changes

alexec merged commit a394a91 into argoproj:master Aug 26, 2021

sarabala1979 mentioned this pull request Sep 2, 2021

v3.1.9 cherry-pick #6654

Closed

61 tasks

sarabala1979 mentioned this pull request Sep 9, 2021

v3.1.10 cherry-pick #6697

Closed

68 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: manifests/quick-start/sso for running locally PROFILE=sso #6503

fix: manifests/quick-start/sso for running locally PROFILE=sso #6503

shioshiota commented Aug 7, 2021

alexec Aug 9, 2021

alexec Aug 9, 2021

shioshiota Aug 10, 2021

shioshiota Aug 10, 2021

codecov bot commented Aug 9, 2021 •

edited

Loading

alexec commented Aug 20, 2021

shioshiota commented Aug 24, 2021

fix: manifests/quick-start/sso for running locally PROFILE=sso #6503

fix: manifests/quick-start/sso for running locally PROFILE=sso #6503

Conversation

shioshiota commented Aug 7, 2021

alexec Aug 9, 2021

Choose a reason for hiding this comment

alexec Aug 9, 2021

Choose a reason for hiding this comment

shioshiota Aug 10, 2021

Choose a reason for hiding this comment

shioshiota Aug 10, 2021

Choose a reason for hiding this comment

codecov bot commented Aug 9, 2021 • edited Loading

Codecov Report

alexec commented Aug 20, 2021

shioshiota commented Aug 24, 2021

codecov bot commented Aug 9, 2021 •

edited

Loading