Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: manifests/quick-start/sso for running locally PROFILE=sso #6503

Merged
merged 2 commits into from
Aug 26, 2021
Merged

fix: manifests/quick-start/sso for running locally PROFILE=sso #6503

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b40e7b6
fix: quick-start/sso for running locally PROFILE=sso
shioshiota Aug 7, 2021
ad02c18
fix: redirectURIs supports both 8080 and 2746 port
shioshiota Aug 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions manifests/quick-start/sso/dex/dex-cm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ data:
staticClients:
- id: argo-server
redirectURIs:
- http://localhost:2746/oauth2/callback
- http://localhost:8080/oauth2/callback
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong, sorry, it should be 2746

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that UI runs on 8080

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is left to be 2746, the dex server returns an Unregistered redirect_uri error when I use SSO login with web UI.
image

Should I not update but add 8080 to URIs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix it: ad02c18

name: Argo Server
secret: ZXhhbXBsZS1hcHAtc2VjcmV0
connectors:
Expand All @@ -30,4 +30,4 @@ data:
userID: 08a8684b-db88-4b73-90a9-3cd1661f5466
kind: ConfigMap
metadata:
name: dex
name: dex
2 changes: 1 addition & 1 deletion manifests/quick-start/sso/overlays/workflow-controller-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ data:
clientSecret:
name: argo-server-sso
key: clientSecret
redirectUrl: http://localhost:2746/oauth2/callback
redirectUrl: http://localhost:8080/oauth2/callback
scopes:
- groups
- email
Expand Down