fix: Fix `gosec` warnings, disable pprof by default. Fixes #6594 #6596

alexec · 2021-08-24T17:06:38Z

Fixes #6594

Signed-off-by: Alex Collins <alex_collins@intuit.com>

terrytangyuan

Great!

Signed-off-by: Alex Collins <alex_collins@intuit.com>

codecov · 2021-08-24T20:49:16Z

Codecov Report

Merging #6596 (11690fe) into master (be07a8a) will increase coverage by 0.02%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##           master    #6596      +/-   ##
==========================================
+ Coverage   48.52%   48.54%   +0.02%     
==========================================
  Files         261      261              
  Lines       18954    18955       +1     
==========================================
+ Hits         9197     9202       +5     
+ Misses       8737     8733       -4     
  Partials     1020     1020

Impacted Files	Coverage Δ
cmd/argo/commands/server.go	`30.76% <0.00%> (-0.24%)`	⬇️
util/util.go	`26.47% <0.00%> (ø)`
workflow/artifacts/git/git.go	`45.79% <ø> (ø)`
workflow/common/common.go	`80.00% <ø> (ø)`
workflow/executor/common/common.go	`48.38% <0.00%> (ø)`
workflow/executor/emissary/emissary.go	`0.00% <0.00%> (ø)`
workflow/util/util.go	`46.26% <50.00%> (ø)`
workflow/executor/executor.go	`24.10% <66.66%> (ø)`
pkg/apis/workflow/v1alpha1/item.go	`77.35% <100.00%> (ø)`
cmd/argo/commands/get.go	`59.76% <0.00%> (+0.87%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be07a8a...11690fe. Read the comment docs.

Signed-off-by: Alex Collins <alex_collins@intuit.com>

alexec · 2021-08-25T16:44:15Z

E2E Tests (test-cli, emissary, mysql)
failed 18 hours ago in 11m 42s

Failed.

alexec · 2021-08-25T18:40:16Z

-- FAIL: TestCLISuite (355.25s)
    --- FAIL: TestCLISuite/TestArchive (9.40s)
        --- FAIL: TestCLISuite/TestArchive/List (0.06s)
   --- FAIL: TestCLISuite/TestLogProblems (19.85s)
   --- FAIL: TestCLISuite/TestRoot (5.27s)
        --- PASS: TestCLISuite/TestRoot/Submit (0.05s)
        --- FAIL: TestCLISuite/TestRoot/List (0.30s)
            --- PASS: TestCLISuite/TestRoot/List/DefaultOutput (0.08s)
            --- PASS: TestCLISuite/TestRoot/List/NameOutput (0.05s)
            --- PASS: TestCLISuite/TestRoot/List/WideOutput (0.06s)
            --- FAIL: TestCLISuite/TestRoot/List/JSONOutput (0.06s)
            --- FAIL: TestCLISuite/TestRoot/List/YAMLOutput (0.05s)
    --- FAIL: TestCLISuite/TestVersion (0.17s)
        --- PASS: TestCLISuite/TestVersion/NoError (0.04s)
        --- FAIL: TestCLISuite/TestVersion/Default (0.04s)
        --- FAIL: TestCLISuite/TestVersion/Short (0.04s)

        	Error:      	"time=\"2021-08-25T16:51:18Z\" level=info msg=\"not enabling pprof debug endpoints\"" does not contain "NAMESPACE"

…rgoproj#3523, argoproj#2063 Signed-off-by: Alex Collins <alex_collins@intuit.com> mre Signed-off-by: Alex Collins <alex_collins@intuit.com> bits Signed-off-by: Alex Collins <alex_collins@intuit.com> fix(executor): Disambiguate PNS executor initialization log (argoproj#6582) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> ci: Disable builds on forks (argoproj#6589) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> fix!: Enable authentication by default on Argo Server `/metrics` endpoint. Fixes argoproj#6592 (argoproj#6595) Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> chore: Upgrade cobra to v1.2.1 (argoproj#6597) Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: Document auth rate limiting. Fixes argoproj#5217 docs: Document IP address logging. Fixes argoproj#5216 fix: Fix `gosec` warnings, disable pprof by default. Fixes argoproj#6594 (argoproj#6596) Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> fix tests Signed-off-by: Alex Collins <alex_collins@intuit.com> fix/skip tests Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> o Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: Fix template-defaults duplicated in docs and add missing whitespace in h1 (argoproj#6601) Signed-off-by: Michael Pöllath <mpoellath.dev@gmail.com> docs: fix continue on failure dag example (argoproj#6609) Signed-off-by: Siebren Zwerver <siebren@siebjee.nl> fix: manifests/quick-start/sso for running locally PROFILE=sso (argoproj#6503) Signed-off-by: Tetsuya Shiota <tetsuya.shiota.1231@gmail.com> chore: Run `make codegen` Signed-off-by: Alex Collins <alex_collins@intuit.com> build: disable UI by default for `make start` docs: Document argoproj#6297 breaking change (argoproj#6616) docs: Remove sym-links from docs (argoproj#6617) Signed-off-by: Alex Collins <alex_collins@intuit.com> upgrade to v0.0.9 Signed-off-by: Alex Collins <alex_collins@intuit.com> fix test Signed-off-by: Alex Collins <alex_collins@intuit.com> fix tests Signed-off-by: Alex Collins <alex_collins@intuit.com> add missing label selector Signed-off-by: Alex Collins <alex_collins@intuit.com> add transport wrappers Signed-off-by: Alex Collins <alex_collins@intuit.com> fix clean-up keys Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> fix: quay.io stuffs Signed-off-by: Alex Collins <alex_collins@intuit.com> fix: support in-cluster correctly Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> fix(controller): Initialize throttler during starting workflow-controller. Fixes: argoproj#6599 (argoproj#6608) Signed-off-by: smile-luobin <smile.luobin@gmail.com> docs: Add slack exit handler example. Resolves argoproj#4152 (argoproj#6612) Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com> fix: Argo Workflow specs link to not go to raw content (argoproj#6624) Signed-off-by: Andrey Melnikov <vafilor@gmail.com> ci: Build Docker manifest with complete dep list (argoproj#6621) Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> fix: Upgrade Dataflow to v0.0.96 (argoproj#6622) Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: Fix incorrect link to examples (argoproj#6630) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> fix: Fixed typo in clusterrole (argoproj#6626) Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com> build: Fix repository prefix (argoproj#6636) Signed-off-by: Alex Collins <alex_collins@intuit.com> feat: Upgrade dataflow to v0.0.98 (argoproj#6637) Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: correct https://bit.ly/book-30m-with-argo-team URL feat(controller): Add a shared index informer for ConfigMaps (argoproj#6644) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Fix duplicated import Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>

alexec added 2 commits August 24, 2021 09:56

fix: Fix gosec warnings. Fixes #6594

481dc2b

Signed-off-by: Alex Collins <alex_collins@intuit.com>

ok

e67ae28

Signed-off-by: Alex Collins <alex_collins@intuit.com>

alexec requested a review from terrytangyuan August 24, 2021 17:06

ok

546305b

Signed-off-by: Alex Collins <alex_collins@intuit.com>

alexec marked this pull request as ready for review August 24, 2021 17:08

terrytangyuan approved these changes Aug 24, 2021

View reviewed changes

ok

48982dd

Signed-off-by: Alex Collins <alex_collins@intuit.com>

alexec requested review from sarabala1979 and whynowy August 24, 2021 20:45

ok

1c54d0b

Signed-off-by: Alex Collins <alex_collins@intuit.com>

alexec enabled auto-merge (squash) August 24, 2021 22:31

sarabala1979 approved these changes Aug 25, 2021

View reviewed changes

alexec added 2 commits August 25, 2021 11:40

Update server.go

de8277b

Update main.go

11690fe

alexec merged commit 8678f00 into master Aug 25, 2021

alexec deleted the fix-6594 branch August 25, 2021 21:15

sarabala1979 mentioned this pull request Sep 2, 2021

v3.1.9 cherry-pick #6654

Closed

61 tasks

sarabala1979 mentioned this pull request Sep 9, 2021

v3.1.10 cherry-pick #6697

Closed

68 tasks

agilgur5 added the type/security Security related label Feb 8, 2024

This was referenced Feb 10, 2024

feat!: Enable pprof server on demand (#16594) argoproj/argo-cd#17068

Open

fix(build): check for env vars in all dirs #12652

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Fix `gosec` warnings, disable pprof by default. Fixes #6594 #6596

fix: Fix `gosec` warnings, disable pprof by default. Fixes #6594 #6596

alexec commented Aug 24, 2021

terrytangyuan left a comment

codecov bot commented Aug 24, 2021 •

edited

Loading

alexec commented Aug 25, 2021

alexec commented Aug 25, 2021

fix: Fix gosec warnings, disable pprof by default. Fixes #6594 #6596

fix: Fix gosec warnings, disable pprof by default. Fixes #6594 #6596

Conversation

alexec commented Aug 24, 2021

terrytangyuan left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 24, 2021 • edited Loading

Codecov Report

alexec commented Aug 25, 2021

alexec commented Aug 25, 2021

fix: Fix `gosec` warnings, disable pprof by default. Fixes #6594 #6596

fix: Fix `gosec` warnings, disable pprof by default. Fixes #6594 #6596

codecov bot commented Aug 24, 2021 •

edited

Loading