feat(controller): Add a shared index informer for ConfigMaps #6644

terrytangyuan · 2021-09-01T14:54:16Z

This PR adds the informer for ConfigMaps based on our discussion. Let me know if this aligns with what you had in mind.

cc @alexec @sarabala1979

Signed-off-by: Yuan Tang terrytangyuan@gmail.com

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

workflow/controller/controller.go

alexec · 2021-09-01T15:09:26Z

workflow/controller/indexes/configmap_index.go

+
+const ConfigMapTypeLabel = "workflows.argoproj.io/configmap-type"
+
+func ConfigMapIndexFunc(obj interface{}) ([]string, error) {


alexec · 2021-09-01T15:09:36Z

workflow/controller/indexes/configmap_index_test.go

+	corev1 "k8s.io/api/core/v1"
+)
+
+func TestConfigMapIndexFunc(t *testing.T) {


workflow/controller/controller.go

workflow/controller/cache/configmap_cache.go

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

codecov · 2021-09-01T15:44:39Z

Codecov Report

Merging #6644 (ae5f2d0) into master (91abb47) will increase coverage by 0.02%.
The diff coverage is 23.07%.

@@            Coverage Diff             @@
##           master    #6644      +/-   ##
==========================================
+ Coverage   48.50%   48.53%   +0.02%     
==========================================
  Files         261      262       +1     
  Lines       18978    18991      +13     
==========================================
+ Hits         9206     9218      +12     
+ Misses       8746     8743       -3     
- Partials     1026     1030       +4

Impacted Files	Coverage Δ
workflow/controller/controller.go	`22.20% <0.00%> (-0.26%)`	⬇️
workflow/controller/indexes/configmap_index.go	`60.00% <60.00%> (ø)`
server/workflow/workflow_server.go	`46.80% <0.00%> (+2.39%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91abb47...ae5f2d0. Read the comment docs.

alexec · 2021-09-01T15:53:24Z

@sarabala1979 this is some pre-work that @terrytangyuan is doing for one of the top voted issues.

…rgoproj#3523, argoproj#2063 Signed-off-by: Alex Collins <alex_collins@intuit.com> mre Signed-off-by: Alex Collins <alex_collins@intuit.com> bits Signed-off-by: Alex Collins <alex_collins@intuit.com> fix(executor): Disambiguate PNS executor initialization log (argoproj#6582) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> ci: Disable builds on forks (argoproj#6589) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> fix!: Enable authentication by default on Argo Server `/metrics` endpoint. Fixes argoproj#6592 (argoproj#6595) Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> chore: Upgrade cobra to v1.2.1 (argoproj#6597) Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: Document auth rate limiting. Fixes argoproj#5217 docs: Document IP address logging. Fixes argoproj#5216 fix: Fix `gosec` warnings, disable pprof by default. Fixes argoproj#6594 (argoproj#6596) Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> fix tests Signed-off-by: Alex Collins <alex_collins@intuit.com> fix/skip tests Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> o Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: Fix template-defaults duplicated in docs and add missing whitespace in h1 (argoproj#6601) Signed-off-by: Michael Pöllath <mpoellath.dev@gmail.com> docs: fix continue on failure dag example (argoproj#6609) Signed-off-by: Siebren Zwerver <siebren@siebjee.nl> fix: manifests/quick-start/sso for running locally PROFILE=sso (argoproj#6503) Signed-off-by: Tetsuya Shiota <tetsuya.shiota.1231@gmail.com> chore: Run `make codegen` Signed-off-by: Alex Collins <alex_collins@intuit.com> build: disable UI by default for `make start` docs: Document argoproj#6297 breaking change (argoproj#6616) docs: Remove sym-links from docs (argoproj#6617) Signed-off-by: Alex Collins <alex_collins@intuit.com> upgrade to v0.0.9 Signed-off-by: Alex Collins <alex_collins@intuit.com> fix test Signed-off-by: Alex Collins <alex_collins@intuit.com> fix tests Signed-off-by: Alex Collins <alex_collins@intuit.com> add missing label selector Signed-off-by: Alex Collins <alex_collins@intuit.com> add transport wrappers Signed-off-by: Alex Collins <alex_collins@intuit.com> fix clean-up keys Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> fix: quay.io stuffs Signed-off-by: Alex Collins <alex_collins@intuit.com> fix: support in-cluster correctly Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> fix(controller): Initialize throttler during starting workflow-controller. Fixes: argoproj#6599 (argoproj#6608) Signed-off-by: smile-luobin <smile.luobin@gmail.com> docs: Add slack exit handler example. Resolves argoproj#4152 (argoproj#6612) Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com> fix: Argo Workflow specs link to not go to raw content (argoproj#6624) Signed-off-by: Andrey Melnikov <vafilor@gmail.com> ci: Build Docker manifest with complete dep list (argoproj#6621) Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> fix: Upgrade Dataflow to v0.0.96 (argoproj#6622) Signed-off-by: Alex Collins <alex_collins@intuit.com> ok Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: Fix incorrect link to examples (argoproj#6630) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> fix: Fixed typo in clusterrole (argoproj#6626) Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com> build: Fix repository prefix (argoproj#6636) Signed-off-by: Alex Collins <alex_collins@intuit.com> feat: Upgrade dataflow to v0.0.98 (argoproj#6637) Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: correct https://bit.ly/book-30m-with-argo-team URL feat(controller): Add a shared index informer for ConfigMaps (argoproj#6644) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Fix duplicated import Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>

feat(controller): Add a shared index informer for ConfigMaps

982b3ff

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

alexec requested changes Sep 1, 2021

View reviewed changes

Address feedback

ae5f2d0

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

alexec approved these changes Sep 1, 2021

View reviewed changes

alexec enabled auto-merge (squash) September 1, 2021 15:53

alexec merged commit 6d46fd9 into argoproj:master Sep 1, 2021

terrytangyuan deleted the configmap-informer branch September 1, 2021 15:58

sarabala1979 mentioned this pull request Sep 2, 2021

v3.1.9 cherry-pick #6654

Closed

61 tasks

terrytangyuan mentioned this pull request Sep 3, 2021

feat: Support loading parameter values from configmaps #6662

Merged

sarabala1979 mentioned this pull request Sep 9, 2021

v3.1.10 cherry-pick #6697

Closed

68 tasks

terrytangyuan mentioned this pull request Nov 30, 2021

Switch to use the new configmaps informer for retrieving configmaps #7304

Open

alexec mentioned this pull request Dec 9, 2021

workflows stuck because controller is not terminating istio sidecar #7214

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(controller): Add a shared index informer for ConfigMaps #6644

feat(controller): Add a shared index informer for ConfigMaps #6644

terrytangyuan commented Sep 1, 2021 •

edited

Loading

alexec Sep 1, 2021

alexec Sep 1, 2021

codecov bot commented Sep 1, 2021

alexec commented Sep 1, 2021


		const ConfigMapTypeLabel = "workflows.argoproj.io/configmap-type"

		func ConfigMapIndexFunc(obj interface{}) ([]string, error) {

feat(controller): Add a shared index informer for ConfigMaps #6644

feat(controller): Add a shared index informer for ConfigMaps #6644

Conversation

terrytangyuan commented Sep 1, 2021 • edited Loading

alexec Sep 1, 2021

Choose a reason for hiding this comment

alexec Sep 1, 2021

Choose a reason for hiding this comment

codecov bot commented Sep 1, 2021

Codecov Report

alexec commented Sep 1, 2021

terrytangyuan commented Sep 1, 2021 •

edited

Loading