HBASE-28187 NPE when flushing a non-existing column family #5553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
…th delete markers (apache#5522)" This reverts commit ce9eabe.
We added a new field in Procedure so the json output is also changed thus we need to change the assertion
|
Looking at the jira description, I think we should add the check at master side? We should reject the request at very beginning. |
…ushRegionProcedure (apache#5548) Co-authored-by: lvhaiping.lhp <lvhaiping.lhp@alibaba-inc.com> Signed-off-by: Duo Zhang <zhangduo@apache.org>
…5520) Signed-off-by: Yu Li <liyu@apache.org>
apache#5528) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
This can only partially solve the problem. There is a scenario, the problem is still exists.
For example: @Override
public void prePut(ObserverContext<RegionCoprocessorEnvironment> c, Put put, WALEdit edit) throws IOException {
HRegion region = (HRegion) c.getEnvironment().getRegion()
region.flushcache(Arrays.asList("non-family".getBytes()), false, FlushLifeCycleTracker.DUMMY);
} |
|
In this PR, I set the result of flush with non-existing family to successful. Mybe we can set the result of flush with non-existing family to |
|
For user request from Admin interface or shell, I think we should reject the request and give users a clear error message, this should be done first. On the CP part, I'm neutral on whether we should deal with the problem. CP is a low level API only expected to be used by experts, so it is the CP's author's duty to not break HBase by wrong input. Of course, I think it is also OK to make our code more robust if it does not introduce overhead or complicate logic. But as you said, we still need to discuss how to deal with the problem, at least I do not think returning success is the correct way... |
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
…tion could lead to ROLLEDBACK state be persisent to procedure store (apache#5567) Signed-off-by: GeorryHuang <huangzhuoyue@apache.org> Signed-off-by: Yi Mei <myimeiyi@gmail.com>
…shot recovery (apache#5570) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.org>
…pache#5507) Signed-off-by: Duo Zhang <zhangduo@apache.org>
…orts in the hbase script (apache#5571) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
…rt to jdk11 JVM test flags (apache#5569) Signed-off-by: Nihal Jain <nihaljain@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
…ache#5560) Fixed the check for an ongoing Snapshot before proceeding with the merge/split region operation. Co-authored-by: lvhaiping.lhp <lvhaiping.lhp@alibaba-inc.com> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Hui Ruan <huiruan@apache.org>
… HBASE-28199 (apache#5563) Signed-off-by: Duo Zhang <zhangduo@apache.org>
Thanks for your repla, I update this PR. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
…witching (apache#5660) Signed-off-by: Duo Zhang <zhangduo@apache.org>
…apache#5631) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
…esponse size (apache#5654) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
…ovider runs with Kerberos instead of Shade authentication (apache#5659) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
…pache#5663) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.6 to 42.0.0. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.6...42.0.0) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Duo Zhang <zhangduo@apache.org>
Co-authored-by: Rajeshbabu Chintaguntla <rajeshbabu@apache.org>
…ept the first region) starts with delete markers (apache#5675) Signed-off-by: David Manning <david.manning@salesforce.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
…se Region End Key for limiting scan to one region only. (apache#5677) Signed-off-by: Viraj Jasani <vjasani@apache.org>
…ry with option to enable Raw Scan (apache#5676) Signed-off-by: David Manning <david.manning@salesforce.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
…pache#5673) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
…apache#5669) Signed-off-by: Balazs Meszaros <meszibali@apache.org>
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@guluo2016 latest code cannot be build with this patch. Please rebase the patch. |
…pache#5687) Bumps [cryptography](https://github.com/pyca/cryptography) from 42.0.0 to 42.0.2. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@42.0.0...42.0.2) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Duo Zhang <zhangduo@apache.org>
…efile has no reader Signed-off-by: Nihal Jain <nihaljain@apache.org> Signed-off-by: Rajeshbabu Chintaguntla <rajeshbabu@apache.org>
…to priority ADMIN_QOS (apache#5558) HBASE-28238 rpcservice should perform some important admin operation to priority ADMIN_QOS (apache#5558) Co-authored-by: selina.yan <selina.yan@huolala.cn>
…into hbase_flush_issue
|
@chrajeshbabu thanks for your comments, The update has been made in a new PR #5692 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details see: HBASE-28187
And even worse, although this flush can be terminated by exception or manually，we are still unable to operate this region because of RegionTooBusyException.