HBASE-28345 Close HBase connection on exit from HBase Shell #5665

stoty · 2024-02-06T15:54:03Z

No description provided.

meszibalu · 2024-02-06T16:11:12Z

hbase-shell/src/main/ruby/shell.rb

@@ -108,6 +108,8 @@ class Shell
    # exit the interactive shell and save that this
    # happend via a call to exit
    def exit(ret = 0)
+      # Non-deamon Netty threadpool in ZK ClientCnxnSocketNetty cannot be shut down otherwise
+      self.hbase.shutdown


If shutdown throws an exception then shell won't exit. Shouldn't we ignore the exceptions?

Makes sense.
Modified to ignore exceptions from close.

Apache-HBase · 2024-02-06T16:15:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 12s	master passed
+1 💚	spotless	0m 45s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 45s	the patch passed
-0 ⚠️	rubocop	0m 3s	The patch generated 1 new + 31 unchanged - 0 fixed = 32 total (was 31)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		9m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5665
Optional Tests	dupname asflicense javac spotless rubocop
uname	Linux 6ded93022709 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `16de74c`
Default Java	Eclipse Adoptium-11.0.17+8
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/1/console
versions	git=2.34.1 maven=3.8.6 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-06T16:20:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 6s	master passed
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 49s	the patch passed
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	6m 44s	hbase-shell in the patch passed.
		14m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5665
Optional Tests	javac javadoc unit
uname	Linux 8a02876405f8 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `16de74c`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/1/testReport/
Max. process+thread count	2011 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-06T16:23:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 49s	master passed
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 41s	the patch passed
+1 💚	javadoc	0m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 1s	hbase-shell in the patch passed.
		17m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5665
Optional Tests	javac javadoc unit
uname	Linux f79a3512fc88 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `16de74c`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/1/testReport/
Max. process+thread count	1965 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-06T16:59:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 20s	master passed
+1 💚	spotless	0m 45s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 44s	the patch passed
-0 ⚠️	rubocop	0m 3s	The patch generated 3 new + 31 unchanged - 0 fixed = 34 total (was 31)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		9m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5665
Optional Tests	dupname asflicense javac spotless rubocop
uname	Linux 127fd7622e73 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `16de74c`
Default Java	Eclipse Adoptium-11.0.17+8
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/2/console
versions	git=2.34.1 maven=3.8.6 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-06T17:05:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 48s	master passed
+1 💚	javadoc	0m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 52s	the patch passed
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	6m 48s	hbase-shell in the patch passed.
		14m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5665
Optional Tests	javac javadoc unit
uname	Linux 4e3def9615d4 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `16de74c`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/2/testReport/
Max. process+thread count	2018 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-06T17:08:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 26s	master passed
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 9s	the patch passed
+1 💚	javadoc	0m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 58s	hbase-shell in the patch passed.
		17m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5665
Optional Tests	javac javadoc unit
uname	Linux dd1030806fe3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `16de74c`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/2/testReport/
Max. process+thread count	1966 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-06T17:44:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 50s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 45s	the patch passed
-0 ⚠️	rubocop	0m 3s	The patch generated 2 new + 31 unchanged - 0 fixed = 33 total (was 31)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		8m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5665
Optional Tests	dupname asflicense javac spotless rubocop
uname	Linux 327bfdd2083c 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `16de74c`
Default Java	Eclipse Adoptium-11.0.17+8
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/3/console
versions	git=2.34.1 maven=3.8.6 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-06T17:49:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 47s	master passed
+1 💚	javadoc	0m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 54s	the patch passed
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	6m 48s	hbase-shell in the patch passed.
		14m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5665
Optional Tests	javac javadoc unit
uname	Linux cf679bcd727c 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `16de74c`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/3/testReport/
Max. process+thread count	2020 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-06T17:52:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 2s	master passed
+1 💚	javadoc	0m 10s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 0s	the patch passed
+1 💚	javadoc	0m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 52s	hbase-shell in the patch passed.
		16m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5665
Optional Tests	javac javadoc unit
uname	Linux cb85570baa55 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `16de74c`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/3/testReport/
Max. process+thread count	1964 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5665/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>

…se Shell (apache#5665) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>

wchevreuil approved these changes Feb 6, 2024

View reviewed changes

meszibalu reviewed Feb 6, 2024

View reviewed changes

HBASE-28345 Close HBase connection on exit from HBase Shell

041fea4

stoty force-pushed the HBASE-28345 branch from 1429eb4 to 041fea4 Compare February 6, 2024 16:45

remove self. as suggested by rubocop

6325199

meszibalu merged commit 3656293 into apache:master Feb 7, 2024

asfgit pushed a commit that referenced this pull request Feb 7, 2024

HBASE-28345 Close HBase connection on exit from HBase Shell (#5665)

5735b83

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>

asfgit pushed a commit that referenced this pull request Feb 7, 2024

HBASE-28345 Close HBase connection on exit from HBase Shell (#5665)

d65844b

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>

asfgit pushed a commit that referenced this pull request Feb 7, 2024

HBASE-28345 Close HBase connection on exit from HBase Shell (#5665)

37f2485

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>

asfgit pushed a commit that referenced this pull request Feb 7, 2024

HBASE-28345 Close HBase connection on exit from HBase Shell (#5665)

a04843d

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>

asfgit pushed a commit that referenced this pull request Feb 8, 2024

HBASE-28345 Close HBase connection on exit from HBase Shell (#5665)

3a81784

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-28345 Close HBase connection on exit from HBase Shell #5665

HBASE-28345 Close HBase connection on exit from HBase Shell #5665

Uh oh!

stoty commented Feb 6, 2024

Uh oh!

meszibalu Feb 6, 2024

Uh oh!

stoty Feb 6, 2024

Uh oh!

Apache-HBase commented Feb 6, 2024

Uh oh!

Apache-HBase commented Feb 6, 2024

Uh oh!

Apache-HBase commented Feb 6, 2024

Uh oh!

Apache-HBase commented Feb 6, 2024

Uh oh!

Apache-HBase commented Feb 6, 2024

Uh oh!

Apache-HBase commented Feb 6, 2024

Uh oh!

Apache-HBase commented Feb 6, 2024

Uh oh!

Apache-HBase commented Feb 6, 2024

Uh oh!

Apache-HBase commented Feb 6, 2024

Uh oh!

Uh oh!

HBASE-28345 Close HBase connection on exit from HBase Shell #5665

HBASE-28345 Close HBase connection on exit from HBase Shell #5665

Uh oh!

Conversation

stoty commented Feb 6, 2024

Uh oh!

meszibalu Feb 6, 2024

Choose a reason for hiding this comment

Uh oh!

stoty Feb 6, 2024

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Feb 6, 2024

Uh oh!

Apache-HBase commented Feb 6, 2024

Uh oh!

Apache-HBase commented Feb 6, 2024

Uh oh!

Apache-HBase commented Feb 6, 2024

Uh oh!

Apache-HBase commented Feb 6, 2024

Uh oh!

Apache-HBase commented Feb 6, 2024

Uh oh!

Apache-HBase commented Feb 6, 2024

Uh oh!

Apache-HBase commented Feb 6, 2024

Uh oh!

Apache-HBase commented Feb 6, 2024

Uh oh!

Uh oh!