HBASE-28204 : Canary can take lot more time If any region (except the first region) starts with delete markers #5522

mihir6692 · 2023-11-14T23:49:01Z

No description provided.

…e markers

Apache-HBase · 2023-11-15T00:22:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 1s	master passed
+1 💚	compile	2m 25s	master passed
+1 💚	checkstyle	0m 35s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 37s	the patch passed
+1 💚	compile	2m 27s	the patch passed
+1 💚	javac	2m 27s	the patch passed
+1 💚	checkstyle	0m 31s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 38s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 32s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		32m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5522/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5522
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 48a1f26becb9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `23c4156`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	77 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5522/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

mihir6692 · 2023-11-15T00:24:18Z

This PR cleanly applies to branch-2, branch-3

Apache-HBase · 2023-11-15T03:58:05Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 54s	master passed
+1 💚	compile	0m 49s	master passed
+1 💚	shadedjars	4m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 38s	the patch passed
+1 💚	compile	0m 48s	the patch passed
+1 💚	javac	0m 48s	the patch passed
+1 💚	shadedjars	4m 53s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	224m 46s	hbase-server in the patch passed.
		247m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5522/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5522
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 81f25c780b0f 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `23c4156`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5522/1/testReport/
Max. process+thread count	5258 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5522/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

d-c-manning · 2023-11-15T04:19:28Z

hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java

      StopWatch stopWatch = new StopWatch();
      startKey = region.getStartKey();
      // Can't do a get on empty start row so do a Scan of first element if any instead.
      if (startKey.length > 0) {


is there any benefit to retaining the Get path? I legitimately don't know.

If there is, it seems like it could be possible to make a change where we use Get only if (startKey.length > 0 && !rawScanEnabled)

But if Get is unnecessary, then your proposal is good, because it reduces the complexity anyway.

I couldn't see any benefit for Get path.

Apache-HBase · 2023-11-15T05:30:42Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 11s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 20s	master passed
+1 💚	compile	0m 55s	master passed
+1 💚	shadedjars	5m 53s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 58s	the patch passed
+1 💚	compile	0m 41s	the patch passed
+1 💚	javac	0m 41s	the patch passed
+1 💚	shadedjars	4m 55s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
-1 ❌	unit	315m 47s	hbase-server in the patch failed.
		339m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5522/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5522
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux de2b31e4cf1a 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `23c4156`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5522/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5522/1/testReport/
Max. process+thread count	4327 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5522/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

mihir6692 · 2023-11-15T05:43:23Z

@sunhelly Can you merge the PR for master, branch-2/2.x and branch-3 ? PR build doesn't show any test failure on Jenkins

mihir6692 · 2023-11-15T06:02:08Z

It shows Test failure but they are not related. One of them is marked as Flaky TestMasterRegionWALCleaner and other one TestRSGroupsAdmin1 is not related.

…th delete markers (#5522)" This reverts commit ce9eabe.

…e markers (#5522) Co-authored-by: Mihir Monani <mihir6692@apache.org> (cherry picked from commit ce9eabe)

…th delete markers (#5522)" This reverts commit ce9eabe.

…th delete markers (#5522)" This reverts commit ef16e9f.

…th delete markers (#5522)" This reverts commit 92be77c.

…th delete markers (#5522)" This reverts commit 6c46d72.

…th delete markers (#5522)" This reverts commit 9171206.

…th delete markers (apache#5522)" This reverts commit ce9eabe.

…e markers (apache#5522) Co-authored-by: Mihir Monani <mihir6692@apache.org> (cherry picked from commit ce9eabe) (cherry picked from commit 9171206) Change-Id: Iaf78f481a7547485b65d1be90f57a8b1982c954a

…th delete markers (apache#5522)" This reverts commit 9171206. (cherry picked from commit 4fa9a63) Change-Id: Id8996842bf31d7bfbbebe741b3f6857857ee7d39

mihir6692 changed the title ~~@HBASE-28204 Canary can take lot more time If region starts with delete markers~~ HBASE-28204 Canary can take lot more time If region starts with delete markers Nov 14, 2023

HBASE-28204 Canary can take lot more time If region starts with delet…

75580f4

…e markers

mihir6692 force-pushed the HBASE-28204 branch from 2ee2352 to 75580f4 Compare November 14, 2023 23:49

mihir6692 changed the title ~~HBASE-28204 Canary can take lot more time If region starts with delete markers~~ HBASE-28204 : Canary can take lot more time If region starts with delete markers Nov 14, 2023

mihir6692 changed the title ~~HBASE-28204 : Canary can take lot more time If region starts with delete markers~~ HBASE-28204 : Canary can take lot more time If any region (except the first region) starts with delete markers Nov 15, 2023

sunhelly approved these changes Nov 15, 2023

View reviewed changes

d-c-manning approved these changes Nov 15, 2023

View reviewed changes

shahrs87 approved these changes Nov 15, 2023

View reviewed changes

shahrs87 merged commit ce9eabe into apache:master Nov 15, 2023

shahrs87 added a commit that referenced this pull request Nov 15, 2023

Revert "HBASE-28204 Canary can take lot more time If region starts wi…

6612215

…th delete markers (#5522)" This reverts commit ce9eabe.

shahrs87 pushed a commit that referenced this pull request Nov 15, 2023

HBASE-28204 Canary can take lot more time If region starts with delet…

ef16e9f

…e markers (#5522) Co-authored-by: Mihir Monani <mihir6692@apache.org> (cherry picked from commit ce9eabe)

shahrs87 pushed a commit that referenced this pull request Nov 15, 2023

HBASE-28204 Canary can take lot more time If region starts with delet…

92be77c

…e markers (#5522) Co-authored-by: Mihir Monani <mihir6692@apache.org> (cherry picked from commit ce9eabe)

shahrs87 pushed a commit that referenced this pull request Nov 15, 2023

HBASE-28204 Canary can take lot more time If region starts with delet…

6c46d72

…e markers (#5522) Co-authored-by: Mihir Monani <mihir6692@apache.org> (cherry picked from commit ce9eabe)

shahrs87 pushed a commit that referenced this pull request Nov 15, 2023

HBASE-28204 Canary can take lot more time If region starts with delet…

9171206

…e markers (#5522) Co-authored-by: Mihir Monani <mihir6692@apache.org> (cherry picked from commit ce9eabe)

virajjasani added a commit that referenced this pull request Dec 1, 2023

Revert "HBASE-28204 Canary can take lot more time If region starts wi…

7f3e400

…th delete markers (#5522)" This reverts commit ce9eabe.

virajjasani added a commit that referenced this pull request Dec 1, 2023

Revert "HBASE-28204 Canary can take lot more time If region starts wi…

5915a55

…th delete markers (#5522)" This reverts commit ef16e9f.

virajjasani added a commit that referenced this pull request Dec 1, 2023

Revert "HBASE-28204 Canary can take lot more time If region starts wi…

0f63885

…th delete markers (#5522)" This reverts commit 92be77c.

virajjasani added a commit that referenced this pull request Dec 1, 2023

Revert "HBASE-28204 Canary can take lot more time If region starts wi…

4f47549

…th delete markers (#5522)" This reverts commit 92be77c.

virajjasani added a commit that referenced this pull request Dec 1, 2023

Revert "HBASE-28204 Canary can take lot more time If region starts wi…

b13a064

…th delete markers (#5522)" This reverts commit 6c46d72.

virajjasani added a commit that referenced this pull request Dec 1, 2023

Revert "HBASE-28204 Canary can take lot more time If region starts wi…

4fa9a63

…th delete markers (#5522)" This reverts commit 9171206.

kadirozde pushed a commit to kadirozde/hbase that referenced this pull request Jan 5, 2024

Revert "HBASE-28204 Canary can take lot more time If region starts wi…

0239b9a

…th delete markers (apache#5522)" This reverts commit ce9eabe.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-28204 : Canary can take lot more time If any region (except the first region) starts with delete markers #5522

HBASE-28204 : Canary can take lot more time If any region (except the first region) starts with delete markers #5522

Uh oh!

mihir6692 commented Nov 14, 2023

Uh oh!

Apache-HBase commented Nov 15, 2023

Uh oh!

mihir6692 commented Nov 15, 2023

Uh oh!

Apache-HBase commented Nov 15, 2023

Uh oh!

d-c-manning Nov 15, 2023

Uh oh!

mihir6692 Nov 15, 2023

Uh oh!

Apache-HBase commented Nov 15, 2023

Uh oh!

mihir6692 commented Nov 15, 2023

Uh oh!

mihir6692 commented Nov 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

HBASE-28204 : Canary can take lot more time If any region (except the first region) starts with delete markers #5522

HBASE-28204 : Canary can take lot more time If any region (except the first region) starts with delete markers #5522

Uh oh!

Conversation

mihir6692 commented Nov 14, 2023

Uh oh!

Apache-HBase commented Nov 15, 2023

Uh oh!

mihir6692 commented Nov 15, 2023

Uh oh!

Apache-HBase commented Nov 15, 2023

Uh oh!

d-c-manning Nov 15, 2023

Choose a reason for hiding this comment

Uh oh!

mihir6692 Nov 15, 2023

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Nov 15, 2023

Uh oh!

mihir6692 commented Nov 15, 2023

Uh oh!

mihir6692 commented Nov 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants